From: Julien Grall <julien.grall@arm.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Cc: "George Dunlap" <george.dunlap@eu.citrix.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Wei Liu" <wl@xen.org>, "Jan Beulich" <JBeulich@suse.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags()
Date: Sun, 7 Jul 2019 19:42:37 +0100 [thread overview]
Message-ID: <96aff7db-67f7-546a-da63-a915cdadd7b9@arm.com> (raw)
In-Reply-To: <20190704191449.22486-1-andrew.cooper3@citrix.com>
Hi Andrew,
On 7/4/19 8:14 PM, Andrew Cooper wrote:
> To allow for further improvements, it is useful to be able to clear more than
> a single flag at once. Rework gnttab_clear_flag() into gnttab_clear_flags()
> which takes a bitmask rather than a bit number.
>
> No practical change yet.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Wei Liu <wl@xen.org>
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> CC: George Dunlap <george.dunlap@eu.citrix.com>
>
> v2:
> * Use unsigned int for the mask parameter
I don't seem to find the request on the ML. Technically the mask can
only be 16-bit. May I ask the reason of this change?
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-07-08 12:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:36 [Xen-devel] [PATCH 0/5] xen/gnttab: XSA-295 followup Andrew Cooper
2019-06-21 9:36 ` [Xen-devel] [PATCH 1/5] xen/gnttab: Reduce complexity when reading grant_entry_header_t Andrew Cooper
2019-06-21 9:36 ` [Xen-devel] [PATCH 2/5] xen/gnttab: Reduce code volume when using union grant_combo Andrew Cooper
2019-06-21 9:36 ` [Xen-devel] [PATCH 3/5] arm/gnttab: Implement stub helpers as static inlines Andrew Cooper
2019-07-04 19:12 ` [Xen-devel] Ping: " Andrew Cooper
2019-07-07 18:38 ` [Xen-devel] " Julien Grall
2019-06-21 9:36 ` [Xen-devel] [PATCH 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags() Andrew Cooper
2019-07-04 19:12 ` [Xen-devel] [PATCH v2 4/5] xen/gnttab: Fold adjacent calls to gnttab_clear_flags() Andrew Cooper
2019-07-04 19:14 ` Andrew Cooper
2019-07-04 19:14 ` [Xen-devel] [PATCH v2 4/5] xen/gnttab: Refactor gnttab_clear_flag() to be gnttab_clear_flags() Andrew Cooper
2019-07-05 9:03 ` Jan Beulich
2019-07-07 18:42 ` Julien Grall [this message]
2019-07-08 18:11 ` Andrew Cooper
2019-07-08 19:27 ` Julien Grall
2019-07-08 20:21 ` Andrew Cooper
2019-07-08 20:28 ` Julien Grall
2019-07-08 20:38 ` Andrew Cooper
2019-07-08 20:54 ` Julien Grall
2019-07-09 13:16 ` Jan Beulich
2019-06-21 9:36 ` [Xen-devel] [PATCH 5/5] xen/gnttab: Fold adjacent calls to gnttab_clear_flags() Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96aff7db-67f7-546a-da63-a915cdadd7b9@arm.com \
--to=julien.grall@arm.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@eu.citrix.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).