From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8A44C2D0E4 for ; Mon, 23 Nov 2020 14:56:35 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52A7620658 for ; Mon, 23 Nov 2020 14:56:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="cym4jwAP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 52A7620658 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.34581.65712 (Exim 4.92) (envelope-from ) id 1khDGF-0003OB-6B; Mon, 23 Nov 2020 14:56:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 34581.65712; Mon, 23 Nov 2020 14:56:11 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khDGF-0003O4-2L; Mon, 23 Nov 2020 14:56:11 +0000 Received: by outflank-mailman (input) for mailman id 34581; Mon, 23 Nov 2020 14:56:09 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khDGD-0003Nz-JV for xen-devel@lists.xenproject.org; Mon, 23 Nov 2020 14:56:09 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b6bd6944-e9b3-43bb-9b57-535183e8b5e9; Mon, 23 Nov 2020 14:56:07 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 97C36ACD5; Mon, 23 Nov 2020 14:56:06 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1khDGD-0003Nz-JV for xen-devel@lists.xenproject.org; Mon, 23 Nov 2020 14:56:09 +0000 X-Inumbo-ID: b6bd6944-e9b3-43bb-9b57-535183e8b5e9 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id b6bd6944-e9b3-43bb-9b57-535183e8b5e9; Mon, 23 Nov 2020 14:56:07 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606143366; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CaMDCDhPysB8w6KfnUoI0F/Qbt77/bl/GFHDOpG5NT0=; b=cym4jwAPdYLMevmYI1quJbbjv8pAClM58R1c+1Vc+ZNR2uJjITu1FVA5qjs1d30pIb3lnr tisbiKdiI2cQlcIKJ47d0zJTn0AnNnMUmjHqupihVBtoEge4yCNVoVmFXahrxkqtPAoEC6 To9SbJi70FHcRnEWG8aaJKMiNiZY1QE= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 97C36ACD5; Mon, 23 Nov 2020 14:56:06 +0000 (UTC) Subject: Re: [PATCH V2 12/23] xen/ioreq: Remove "hvm" prefixes from involved function names To: Oleksandr , Paul Durrant Cc: Oleksandr Tyshchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Jun Nakajima , Kevin Tian , Julien Grall , xen-devel@lists.xenproject.org References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-13-git-send-email-olekstysh@gmail.com> <04a81b7e-213a-968b-048c-dfa68b6e3b0d@gmail.com> From: Jan Beulich Message-ID: <96e6622c-08b3-ff85-75f1-14c8b7cd6d6e@suse.com> Date: Mon, 23 Nov 2020 15:56:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <04a81b7e-213a-968b-048c-dfa68b6e3b0d@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 23.11.2020 15:39, Oleksandr wrote: > As it was agreed, below the list of proposed renaming (naming) within > current series. Thanks for compiling this. A couple of suggestions for consideration: > 1. Global (existing): > hvm_map_mem_type_to_ioreq_server     -> ioreq_server_map_mem_type > hvm_select_ioreq_server              -> ioreq_server_select > hvm_send_ioreq                       -> ioreq_send > hvm_ioreq_init                       -> ioreq_init ioreq_domain_init() (or, imo less desirable domain_ioreq_init())? > hvm_destroy_all_ioreq_servers        -> ioreq_server_destroy_all > hvm_all_ioreq_servers_add_vcpu       -> ioreq_server_add_vcpu_all > hvm_all_ioreq_servers_remove_vcpu    -> ioreq_server_remove_vcpu_all > hvm_broadcast_ioreq                  -> ioreq_broadcast > hvm_create_ioreq_server              -> ioreq_server_create > hvm_get_ioreq_server_info            -> ioreq_server_get_info > hvm_map_io_range_to_ioreq_server     -> ioreq_server_map_io_range > hvm_unmap_io_range_from_ioreq_server -> ioreq_server_unmap_io_range > hvm_set_ioreq_server_state           -> ioreq_server_set_state > hvm_destroy_ioreq_server             -> ioreq_server_destroy > hvm_get_ioreq_server_frame           -> ioreq_server_get_frame > hvm_ioreq_needs_completion           -> ioreq_needs_completion > hvm_mmio_first_byte                  -> ioreq_mmio_first_byte > hvm_mmio_last_byte                   -> ioreq_mmio_last_byte > send_invalidate_req                  -> ioreq_signal_mapcache_invalidate > > handle_hvm_io_completion             -> handle_io_completion For this one I'm not sure what to suggest, but I'm not overly happy with the name. > hvm_io_pending                       -> io_pending vcpu_ioreq_pending() or vcpu_any_ioreq_pending()? > 2. Global (new): > arch_io_completion > arch_ioreq_server_map_pages > arch_ioreq_server_unmap_pages > arch_ioreq_server_enable > arch_ioreq_server_disable > arch_ioreq_server_destroy > arch_ioreq_server_map_mem_type > arch_ioreq_server_destroy_all > arch_ioreq_server_get_type_addr > arch_ioreq_init Assuming this is the arch hook of the similarly named function further up, a similar adjustment may then be wanted here. > domain_has_ioreq_server > > > 3. Local (existing) in common ioreq.c: > hvm_alloc_ioreq_mfn               -> ioreq_alloc_mfn > hvm_free_ioreq_mfn                -> ioreq_free_mfn These two are server functions, so should imo be ioreq_server_...(). However, if they're static (as they're now), no distinguishing prefix is strictly necessary, i.e. alloc_mfn() and free_mfn() may be fine. The two names may be too short for Paul's taste, though. Some similar shortening may be possible for some or all of the ones below here. Jan > hvm_update_ioreq_evtchn           -> ioreq_update_evtchn > hvm_ioreq_server_add_vcpu         -> ioreq_server_add_vcpu > hvm_ioreq_server_remove_vcpu      -> ioreq_server_remove_vcpu > hvm_ioreq_server_remove_all_vcpus -> ioreq_server_remove_all_vcpus > hvm_ioreq_server_alloc_pages      -> ioreq_server_alloc_pages > hvm_ioreq_server_free_pages       -> ioreq_server_free_pages > hvm_ioreq_server_free_rangesets   -> ioreq_server_free_rangesets > hvm_ioreq_server_alloc_rangesets  -> ioreq_server_alloc_rangesets > hvm_ioreq_server_enable           -> ioreq_server_enable > hvm_ioreq_server_disable          -> ioreq_server_disable > hvm_ioreq_server_init             -> ioreq_server_init > hvm_ioreq_server_deinit           -> ioreq_server_deinit > hvm_send_buffered_ioreq           -> ioreq_send_buffered > > hvm_wait_for_io                   -> wait_for_io > > 4. Local (existing) in x86 ioreq.c: > Everything related to legacy interface (hvm_alloc_legacy_ioreq_gfn, etc) > are going > to remain as is. > > >