From: David Scott <dave@recoil.org>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [PATCH 7/7] oxenstored: honour XEN_RUN_DIR
Date: Wed, 15 Jun 2016 20:43:38 +0100 [thread overview]
Message-ID: <AB0CD64D-7784-41C9-8BD7-E55C98885D37@recoil.org> (raw)
In-Reply-To: <1465989309-12418-8-git-send-email-wei.liu2@citrix.com>
> On 15 Jun 2016, at 12:15, Wei Liu <wei.liu2@citrix.com> wrote:
>
> Move default the pid file under XEN_RUN_DIR. Note that it changes the
> location from /var/run to /var/run/xen.
>
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Dave Scott <dave@recoil.org>
> ---
> tools/ocaml/xenstored/xenstored.ml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/ocaml/xenstored/xenstored.ml b/tools/ocaml/xenstored/xenstored.ml
> index 30570ed..7ea4026 100644
> --- a/tools/ocaml/xenstored/xenstored.ml
> +++ b/tools/ocaml/xenstored/xenstored.ml
> @@ -81,7 +81,7 @@ let config_filename cf =
> | Some name -> name
> | None -> Define.default_config_dir ^ "/oxenstored.conf"
>
> -let default_pidfile = "/var/run/xenstored.pid"
> +let default_pidfile = Paths.xen_run_dir ^ "/xenstored.pid"
>
> let ring_scan_interval = ref 20
>
> --
> 2.1.4
>
Looks fine to me.
Acked-by: David Scott <dave@recoil.org>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-15 19:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 11:15 [PATCH 0/7] Honour more configure variables in various places (iteration 3) Wei Liu
2016-06-15 11:15 ` [PATCH 1/7] xenconsoled: honour XEN_RUN_DIR Wei Liu
2016-06-15 11:15 ` [PATCH 2/7] tools/helper: honour XEN_RUN_DIR in init-xenstore-domain.c Wei Liu
2016-07-08 17:25 ` Ian Jackson
2016-07-11 10:38 ` Wei Liu
2016-06-15 11:15 ` [PATCH 3/7] hotplug/FreeBSD: honour XEN_RUN_DIR Wei Liu
2016-06-15 16:18 ` Roger Pau Monné
2016-07-08 17:25 ` Ian Jackson
2016-06-15 11:15 ` [PATCH 4/7] hotplug/NetBSD: " Wei Liu
2016-06-15 16:16 ` Roger Pau Monné
2016-07-08 17:26 ` Ian Jackson
2016-06-15 11:15 ` [PATCH 5/7] hotplug/Linux: " Wei Liu
2016-06-15 16:17 ` Roger Pau Monné
2016-07-08 17:26 ` Ian Jackson
2016-06-15 11:15 ` [PATCH 6/7] libxenstat: " Wei Liu
2016-07-08 17:27 ` Ian Jackson
2016-07-11 10:38 ` Wei Liu
2016-06-15 11:15 ` [PATCH 7/7] oxenstored: " Wei Liu
2016-06-15 19:43 ` David Scott [this message]
2016-07-08 17:27 ` Ian Jackson
2016-07-08 17:28 ` Ian Jackson
2016-07-11 10:38 ` Wei Liu
2016-07-02 10:21 ` [PATCH 0/7] Honour more configure variables in various places (iteration 3) Wei Liu
2016-07-08 17:25 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AB0CD64D-7784-41C9-8BD7-E55C98885D37@recoil.org \
--to=dave@recoil.org \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).