From: Rahul Singh <Rahul.Singh@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Julien Grall <julien@xen.org>,
Bertrand Marquis <Bertrand.Marquis@arm.com>,
"Volodymyr_Babchuk@epam.com" <Volodymyr_Babchuk@epam.com>,
"brian.woods@xilinx.com" <brian.woods@xilinx.com>
Subject: Re: [PATCH v3 0/3] Generic SMMU Bindings
Date: Tue, 2 Feb 2021 16:07:08 +0000 [thread overview]
Message-ID: <C094E054-885F-4363-ABF3-E0FB4DDD7A2A@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2101261435550.2568@sstabellini-ThinkPad-T480s>
Hello Stefano,
> On 26 Jan 2021, at 10:58 pm, Stefano Stabellini <sstabellini@kernel.org> wrote:
>
> Hi all,
>
> This series introduces support for the generic SMMU bindings to
> xen/drivers/passthrough/arm/smmu.c.
>
> The last version of the series was
> https://marc.info/?l=xen-devel&m=159539053406643
>
> I realize that it is late for 4.15 -- I think it is OK if this series
> goes in afterwards.
I tested the series on the Juno board it is woking fine.
I found one issue in SMMU driver while testing this series that is not related to this series but already existing issue in SMMU driver.
If there are more than one device behind SMMU and they share the same Stream-Id, SMMU driver is creating the new SMR entry without checking the already configured SMR entry if SMR entry correspond to stream-id is already configured. Because of this I observed the stream match conflicts on Juno board.
(XEN) smmu: /iommu@7fb30000: Unexpected global fault, this could be serious
(XEN) smmu: /iommu@7fb30000: GFSR 0x00000004, GFSYNR0 0x00000006, GFSYNR1 0x00000000, GFSYNR2 0x00000000
Below two patches is required to be ported to Xen to fix the issue from Linux driver.
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/iommu/arm-smmu.c?h=linux-5.8.y&id=1f3d5ca43019bff1105838712d55be087d93c0da
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/iommu/arm-smmu.c?h=linux-5.8.y&id=21174240e4f4439bb8ed6c116cdbdc03eba2126e
Regards,
Rahul
>
> Cheers,
>
> Stefano
>
>
> Brian Woods (3):
> arm,smmu: switch to using iommu_fwspec functions
> arm,smmu: restructure code in preparation to new bindings support
> arm,smmu: add support for generic DT bindings. Implement add_device and dt_xlate.
>
> xen/drivers/passthrough/arm/smmu.c | 162 ++++++++++++++++++++++++----------
> xen/drivers/passthrough/device_tree.c | 24 ++---
> 2 files changed, 123 insertions(+), 63 deletions(-)
next prev parent reply other threads:[~2021-02-02 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 22:58 [PATCH v3 0/3] Generic SMMU Bindings Stefano Stabellini
2021-01-26 22:58 ` [PATCH v3 1/3] arm,smmu: switch to using iommu_fwspec functions Stefano Stabellini
2021-02-02 16:07 ` Rahul Singh
2021-01-26 22:58 ` [PATCH v3 2/3] arm,smmu: restructure code in preparation to new bindings support Stefano Stabellini
2021-02-02 16:09 ` Rahul Singh
2021-01-26 22:58 ` [PATCH v3 3/3] arm,smmu: add support for generic DT bindings. Implement add_device and dt_xlate Stefano Stabellini
2021-02-02 16:09 ` Rahul Singh
2021-02-02 16:07 ` Rahul Singh [this message]
2021-02-02 17:44 ` [PATCH v3 0/3] Generic SMMU Bindings Stefano Stabellini
2021-02-02 17:50 ` Julien Grall
2021-02-02 18:27 ` Stefano Stabellini
2021-02-02 18:43 ` Julien Grall
2021-02-03 17:14 ` Rahul Singh
2021-04-05 15:23 ` Julien Grall
2021-04-06 23:59 ` Stefano Stabellini
2021-04-07 15:43 ` Rahul Singh
2021-04-10 0:27 ` Stefano Stabellini
2021-04-12 10:20 ` Rahul Singh
2021-04-13 0:27 ` Stefano Stabellini
2021-04-14 10:42 ` Rahul Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C094E054-885F-4363-ABF3-E0FB4DDD7A2A@arm.com \
--to=rahul.singh@arm.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=brian.woods@xilinx.com \
--cc=julien@xen.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).