From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Sujkov Subject: Re: Xentrace on Xilinx ARM Date: Wed, 9 Mar 2016 13:41:45 +0200 Message-ID: References: <1457192589.2959.603.camel@citrix.com> <1457440918.3102.193.camel@citrix.com> <56DF1DA3.5000007@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a1147a38ce626ec052d9c2fed Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ben Sanda Cc: "stefano.stabellini" , George Dunlap , Dario Faggioli , George Dunlap , "xen-devel@lists.xen.org" , Julien Grall List-Id: xen-devel@lists.xenproject.org --001a1147a38ce626ec052d9c2fed Content-Type: multipart/alternative; boundary=001a1147a38ce626e6052d9c2feb --001a1147a38ce626e6052d9c2feb Content-Type: text/plain; charset=UTF-8 Hi Ben, see the patch attached. It's a bit dirty still (that's why it wasn't upstreamed long time ago), but you can obviously look through it and gain some information. On 8 March 2016 at 22:51, Ben Sanda wrote: > George, > > >FWIW, on my "to-do" list for xenalyze for years has been to have the > xentrace > >process query something (either Xen or Linux) to find the hz rate, and > then > >write that at the beginning of the xentrace file, so that xenalyze could > just > >pick that up and use it. Since you're doing some work on xentrace / > xenalyze > >anyway, you might think about adding that to your "to-do" list -- it > doesn't > >seem conceptually like it would be that hard. > > Since I'm in the code base anyway right now I'll give it a look. I was > wondering > about that for the xenalyze hertz parameter. I had assumed initially > xentrace > embedded the value somehow already. Is there any documentation as to the > binary > format xentrace outputs? Or is it best just to look at the code and figure > it > out? I guess the main thing would be providing a common interface for both > ARM > and x86 but the common trace.c has a get frequency function that's > implemented > by both so we should be able to query it and shove in the data. > > >The other thing that might be useful is information about the architecture > >you're running on -- right now it assumes intel, and will crash tracing a > file > >generated on an AMD box unless you specify --svm-mode. Adding a trace > record > >that indicates "Intel / AMD / ARM" would also make things a lot easier. > > I didn't run into any issue with xenalyze analyzing the ARM generated > trace file > (I didn't give it any special flag). What does --svm-mode modify? The > endedness? > I can look quick into that as well. > > Thanks, > Ben > -- Regards, Paul Sujkov --001a1147a38ce626e6052d9c2feb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Ben,

see the patch attached. It'= s a bit dirty still (that's why it wasn't upstreamed long time ago)= , but you can obviously look through it and gain some information.

On 8 March 201= 6 at 22:51, Ben Sanda <Ben.Sanda@dornerworks.com> wr= ote:
George,

>FWIW, on my "to-do" list for xenalyze for years has been to h= ave the xentrace
>process query something (either Xen or Linux) to find the hz rate, and = then
>write that at the beginning of the xentrace file, so that xenalyze coul= d just
>pick that up and use it.=C2=A0 Since you're doing some work on xent= race / xenalyze
>anyway, you might think about adding that to your "to-do" lis= t -- it doesn't
>seem conceptually like it would be that hard.

Since I'm in the code base anyway right now I'll give it a l= ook. I was wondering
about that for the xenalyze hertz parameter. I had assumed initially xentra= ce
embedded the value somehow already. Is there any documentation as to the bi= nary
format xentrace outputs? Or is it best just to look at the code and figure = it
out? I guess the main thing would be providing a common interface for both = ARM
and x86 but the common trace.c has a get frequency function that's impl= emented
by both so we should be able to query it and shove in the data.

>The other thing that might be useful is information about the architect= ure
>you're running on -- right now it assumes intel, and will crash tra= cing a file
>generated on an AMD box unless you specify --svm-mode.=C2=A0 Adding a t= race record
>that indicates "Intel / AMD / ARM" would also make things a l= ot easier.

I didn't run into any issue with xenalyze analyzing the ARM gene= rated trace file
(I didn't give it any special flag). What does --svm-mode modify? The e= ndedness?
I can look quick into that as well.

Thanks,
Ben



--
Regards, Paul Sujkov
--001a1147a38ce626e6052d9c2feb-- --001a1147a38ce626ec052d9c2fed Content-Type: text/x-patch; charset=US-ASCII; name="0001-ARM-xentrace-and-xenbaked-fix.patch" Content-Disposition: attachment; filename="0001-ARM-xentrace-and-xenbaked-fix.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_ilkrwshz0 RnJvbSA0Mjk5MjRhZjZjMDYzMzk2OGM1Y2E0YmM5Y2UyNzdmN2RlYWEwMzY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQYXZsbyBTdWlrb3YgPHBhdmxvLnN1aWtvdkBnbG9iYWxsb2dp Yy5jb20+CkRhdGU6IFdlZCwgMjcgSmFuIDIwMTYgMTQ6NTY6MDEgKzAyMDAKU3ViamVjdDogW1BB VENIIDEvNV0gQVJNIHhlbnRyYWNlIGFuZCB4ZW5iYWtlZCBmaXgKCkZpeCBmb3IgdHJhY2VzIGZv ciBBUk0uIE1ha2VzIHhlbnRyYWNlIGFuZCB4ZW5iYWtlZCB3b3JrIGNvcnJlY3RseQppbiBEb20w LgoKQ2hhbmdlLUlkOiBJNDQ1ZmU5NmE1MGViZWRhNzQzN2VmMzdkYTUyYWQ4N2Q0NmZkODIwMgpT aWduZWQtb2ZmLWJ5OiBQYXZsbyBTdWlrb3YgPHBhdmxvLnN1aWtvdkBnbG9iYWxsb2dpYy5jb20+ Ci0tLQogdG9vbHMvZmxhc2svcG9saWN5L3BvbGljeS9tb2R1bGVzL3hlbi94ZW4udGUgfCAgNCAr KysrCiB4ZW4vYXJjaC9hcm0vZ2ljLmMgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAyICst CiB4ZW4vYXJjaC9hcm0vbW0uYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDEzICsrKysr KysrKysrLS0KIHhlbi9hcmNoL2FybS9wMm0uYyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg IDQgKysrKwogeGVuL2FyY2gvYXJtL3NldHVwLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCAg MyArKysKIHhlbi9jb21tb24vc3BpbmxvY2suYyAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIg Ky0KIHhlbi9pbmNsdWRlL2FzbS1hcm0vdGltZS5oICAgICAgICAgICAgICAgICAgIHwgIDggKysr KysrLS0KIDcgZmlsZXMgY2hhbmdlZCwgMzAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS90b29scy9mbGFzay9wb2xpY3kvcG9saWN5L21vZHVsZXMveGVuL3hlbi50 ZSBiL3Rvb2xzL2ZsYXNrL3BvbGljeS9wb2xpY3kvbW9kdWxlcy94ZW4veGVuLnRlCmluZGV4IDgx YTBiOWMuLjcyOTA4MTMgMTAwNjQ0Ci0tLSBhL3Rvb2xzL2ZsYXNrL3BvbGljeS9wb2xpY3kvbW9k dWxlcy94ZW4veGVuLnRlCisrKyBiL3Rvb2xzL2ZsYXNrL3BvbGljeS9wb2xpY3kvbW9kdWxlcy94 ZW4veGVuLnRlCkBAIC04NCw2ICs4NCw4IEBAIGFsbG93IGRvbTBfdCBkb20wX3Q6ZG9tYWluMiB7 CiB9OwogYWxsb3cgZG9tMF90IGRvbTBfdDpyZXNvdXJjZSB7IGFkZCByZW1vdmUgfTsKIAorYWxs b3cgZG9tMF90IGRvbXhlbl90Om1tdSB7IG1lbW9yeW1hcCBtYXBfd3JpdGUgfTsKKwogIyBUaGVz ZSBwZXJtaXNzaW9ucyBhbGxvdyB1c2luZyB0aGUgRkxBU0sgc2VjdXJpdHkgc2VydmVyIHRvIGNv bXB1dGUgYWNjZXNzCiAjIGNoZWNrcyBsb2NhbGx5LCB3aGljaCBjb3VsZCBiZSB1c2VkIGJ5IGEg ZG9tYWluIG9yIHNlcnZpY2UgKHN1Y2ggYXMgeGVuc3RvcmUpCiAjIHRoYXQgZG9lcyBub3QgaGF2 ZSBpdHMgb3duIHNlY3VyaXR5IHNlcnZlciB0byBtYWtlIGFjY2VzcyBkZWNpc2lvbnMgYmFzZWQg b24KQEAgLTE1Miw2ICsxNTQsOCBAQCBhbGxvdyBkb21kX3QgZG9tZF90OmRvbWFpbjIgewogfTsK IGFsbG93IGRvbTBfdCBkb21kX3Q6cmVzb3VyY2UgeyBhZGQgcmVtb3ZlIH07CiAKK2FsbG93IGRv bWRfdCBkb214ZW5fdDptbXUgeyBtZW1vcnltYXAgbWFwX3JlYWQgbWFwX3dyaXRlIH07CisKIGFs bG93IGRvbTBfdCBkb21kX3Q6ZG9tYWluMiBzZXRfMTFfbWFwcGluZzsKIAogIyBUaGVzZSBwZXJt aXNzaW9ucyBhbGxvdyB1c2luZyB0aGUgRkxBU0sgc2VjdXJpdHkgc2VydmVyIHRvIGNvbXB1dGUg YWNjZXNzCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vZ2ljLmMgYi94ZW4vYXJjaC9hcm0vZ2lj LmMKaW5kZXggYWUwODc3NC4uZjdjMGEyNSAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL2dpYy5j CisrKyBiL3hlbi9hcmNoL2FybS9naWMuYwpAQCAtNjksNyArNjksNyBAQCB1bnNpZ25lZCBpbnQg Z2ljX251bWJlcl9saW5lcyh2b2lkKQogCiB2b2lkIGdpY19zYXZlX3N0YXRlKHN0cnVjdCB2Y3B1 ICp2KQogewotICAgIEFTU0VSVCghbG9jYWxfaXJxX2lzX2VuYWJsZWQoKSk7CisvKiAgICBBU1NF UlQoIWxvY2FsX2lycV9pc19lbmFibGVkKCkpOyAqLwogICAgIEFTU0VSVCghaXNfaWRsZV92Y3B1 KHYpKTsKIAogICAgIC8qIE5vIG5lZWQgZm9yIHNwaW5sb2NrcyBoZXJlIGJlY2F1c2UgaW50ZXJy dXB0cyBhcmUgZGlzYWJsZWQgYXJvdW5kCmRpZmYgLS1naXQgYS94ZW4vYXJjaC9hcm0vbW0uYyBi L3hlbi9hcmNoL2FybS9tbS5jCmluZGV4IGQyMGE3ZDAuLjJkZDhlMDYgMTAwNjQ0Ci0tLSBhL3hl bi9hcmNoL2FybS9tbS5jCisrKyBiL3hlbi9hcmNoL2FybS9tbS5jCkBAIC0xMDg1LDcgKzEwODUs MTUgQEAgaW50IHhlbm1lbV9hZGRfdG9fcGh5c21hcF9vbmUoCiAgICAgewogICAgICAgICBzdHJ1 Y3QgZG9tYWluICpvZDsKICAgICAgICAgcDJtX3R5cGVfdCBwMm10OwotICAgICAgICBvZCA9IHJj dV9sb2NrX2RvbWFpbl9ieV9hbnlfaWQoZm9yZWlnbl9kb21pZCk7CisgICAgICAgIC8qIG9kID0g cmN1X2xvY2tfZG9tYWluX2J5X2FueV9pZChmb3JlaWduX2RvbWlkKTsgKi8KKworICAgICAgICBp ZiAoZm9yZWlnbl9kb21pZCA9PSBkb21feGVuLT5kb21haW5faWQpIHsKKyAgICAgICAgICAgIHJj dV9sb2NrX2RvbWFpbihkb21feGVuKTsKKyAgICAgICAgICAgIG9kID0gZG9tX3hlbjsKKyAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgIG9kID0gcmN1X2xvY2tfZG9tYWluX2J5X2FueV9pZChm b3JlaWduX2RvbWlkKTsKKyAgICAgICAgfQorCiAgICAgICAgIGlmICggb2QgPT0gTlVMTCApCiAg ICAgICAgICAgICByZXR1cm4gLUVTUkNIOwogCkBAIC0xMTEyLDcgKzExMjAsOCBAQCBpbnQgeGVu bWVtX2FkZF90b19waHlzbWFwX29uZSgKICAgICAgICAgICAgIHJldHVybiAtRUlOVkFMOwogICAg ICAgICB9CiAKLSAgICAgICAgaWYgKCAhcDJtX2lzX3JhbShwMm10KSApCisgICAgICAgIC8qIGlm ICggIXAybV9pc19yYW0ocDJtdCkgKSAqLworICAgICAgICBpZiAoIChmb3JlaWduX2RvbWlkICE9 IGRvbV94ZW4tPmRvbWFpbl9pZCkgJiYgIXAybV9pc19yYW0ocDJtdCkgKQogICAgICAgICB7CiAg ICAgICAgICAgICBwdXRfcGFnZShwYWdlKTsKICAgICAgICAgICAgIHJjdV91bmxvY2tfZG9tYWlu KG9kKTsKZGlmZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9wMm0uYyBiL3hlbi9hcmNoL2FybS9wMm0u YwppbmRleCA4ODA5ZjVhLi4xNjNiNjliIDEwMDY0NAotLS0gYS94ZW4vYXJjaC9hcm0vcDJtLmMK KysrIGIveGVuL2FyY2gvYXJtL3AybS5jCkBAIC0xNTksNiArMTU5LDEwIEBAIHBhZGRyX3QgcDJt X2xvb2t1cChzdHJ1Y3QgZG9tYWluICpkLCBwYWRkcl90IHBhZGRyLCBwMm1fdHlwZV90ICp0KQog CiAgICAgQlVJTERfQlVHX09OKFRISVJEX01BU0sgIT0gUEFHRV9NQVNLKTsKIAorICAgIGlmIChE T01JRF9YRU4gPT0gZC0+ZG9tYWluX2lkKSB7CisgICAgICAgIHJldHVybiBwYWRkcjsKKyAgICB9 CisKICAgICAvKiBBbGxvdyB0IHRvIGJlIE5VTEwgKi8KICAgICB0ID0gdCA/OiAmX3Q7CiAKZGlm ZiAtLWdpdCBhL3hlbi9hcmNoL2FybS9zZXR1cC5jIGIveGVuL2FyY2gvYXJtL3NldHVwLmMKaW5k ZXggNDdiMmQ5Ni4uNWU1MzQ0MCAxMDA2NDQKLS0tIGEveGVuL2FyY2gvYXJtL3NldHVwLmMKKysr IGIveGVuL2FyY2gvYXJtL3NldHVwLmMKQEAgLTM2LDYgKzM2LDcgQEAKICNpbmNsdWRlIDx4ZW4v cGZuLmg+CiAjaW5jbHVkZSA8eGVuL3ZtYXAuaD4KICNpbmNsdWRlIDx4ZW4vbGliZmR0L2xpYmZk dC5oPgorI2luY2x1ZGUgPHhlbi90cmFjZS5oPgogI2luY2x1ZGUgPGFzbS9wYWdlLmg+CiAjaW5j bHVkZSA8YXNtL2N1cnJlbnQuaD4KICNpbmNsdWRlIDxhc20vc2V0dXAuaD4KQEAgLTgyNyw2ICs4 MjgsOCBAQCB2b2lkIF9faW5pdCBzdGFydF94ZW4odW5zaWduZWQgbG9uZyBib290X3BoeXNfb2Zm c2V0LAogICAgIC8qIFNjcnViIFJBTSB0aGF0IGlzIHN0aWxsIGZyZWUgYW5kIHNvIG1heSBnbyB0 byBhbiB1bnByaXZpbGVnZWQgZG9tYWluLiAqLwogICAgIHNjcnViX2hlYXBfcGFnZXMoKTsKIAor ICAgIGluaXRfdHJhY2VfYnVmcygpOworCiAgICAgaW5pdF9jb25zdHJ1Y3RvcnMoKTsKIAogICAg IGNvbnNvbGVfZW5kYm9vdCgpOwpkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9zcGlubG9jay5jIGIv eGVuL2NvbW1vbi9zcGlubG9jay5jCmluZGV4IGY5ZjE5YTguLjhjNDBhY2EgMTAwNjQ0Ci0tLSBh L3hlbi9jb21tb24vc3BpbmxvY2suYworKysgYi94ZW4vY29tbW9uL3NwaW5sb2NrLmMKQEAgLTEz NCw3ICsxMzQsNyBAQCB2b2lkIF9zcGluX2xvY2tfaXJxKHNwaW5sb2NrX3QgKmxvY2spCiB7CiAg ICAgTE9DS19QUk9GSUxFX1ZBUjsKIAotICAgIEFTU0VSVChsb2NhbF9pcnFfaXNfZW5hYmxlZCgp KTsKKy8qICAgIEFTU0VSVChsb2NhbF9pcnFfaXNfZW5hYmxlZCgpKTsgKi8KICAgICBsb2NhbF9p cnFfZGlzYWJsZSgpOwogICAgIGNoZWNrX2xvY2soJmxvY2stPmRlYnVnKTsKICAgICB3aGlsZSAo IHVubGlrZWx5KCFfcmF3X3NwaW5fdHJ5bG9jaygmbG9jay0+cmF3KSkgKQpkaWZmIC0tZ2l0IGEv eGVuL2luY2x1ZGUvYXNtLWFybS90aW1lLmggYi94ZW4vaW5jbHVkZS9hc20tYXJtL3RpbWUuaApp bmRleCBkNTQ0YjViLi5hMTZkMzU1IDEwMDY0NAotLS0gYS94ZW4vaW5jbHVkZS9hc20tYXJtL3Rp bWUuaAorKysgYi94ZW4vaW5jbHVkZS9hc20tYXJtL3RpbWUuaApAQCAtNSwxMSArNSwxNSBAQAog ICAgIERUX01BVENIX0NPTVBBVElCTEUoImFybSxhcm12Ny10aW1lciIpLCBcCiAgICAgRFRfTUFU Q0hfQ09NUEFUSUJMRSgiYXJtLGFybXY4LXRpbWVyIikKIAotdHlwZWRlZiB1bnNpZ25lZCBsb25n IGN5Y2xlc190OworLyogdHlwZWRlZiB1bnNpZ25lZCBsb25nIGN5Y2xlc190OyAqLworI2luY2x1 ZGUgPGFzbS9yZWdzLmg+CisKK3R5cGVkZWYgdWludDY0X3QgY3ljbGVzX3Q7CiAKIHN0YXRpYyBp bmxpbmUgY3ljbGVzX3QgZ2V0X2N5Y2xlcyAodm9pZCkKIHsKLSAgICAgICAgcmV0dXJuIDA7Cisg ICAgLyogcmV0dXJuIDA7ICovCisgICAgcmV0dXJuIFJFQURfU1lTUkVHNjQoQ05UUENUX0VMMCk7 CiB9CiAKIC8qIExpc3Qgb2YgdGltZXIncyBJUlEgKi8KLS0gCjIuNy4wCgo= --001a1147a38ce626ec052d9c2fed Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMueGVuLm9y Zy94ZW4tZGV2ZWwK --001a1147a38ce626ec052d9c2fed--