From: George Dunlap <dunlapg@umich.edu>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Tim Deegan <tim@xen.org>, Ian Jackson <ian.jackson@eu.citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v3 1/8] blkif: document how FreeBSD uses the physical-device backend node
Date: Thu, 31 Mar 2016 17:19:49 +0100 [thread overview]
Message-ID: <CAFLBxZYyG+W09LsuMFA58W=y2hp5D-ro9JHrJ1S1iJga7V3g-w@mail.gmail.com> (raw)
In-Reply-To: <1459436979-7475-2-git-send-email-roger.pau@citrix.com>
On Thu, Mar 31, 2016 at 4:09 PM, Roger Pau Monne <roger.pau@citrix.com> wrote:
> FreeBSD blkback uses the physical-device-path xenstore node in order to
> fetch the path to the underlying backing storage (either a block device or
> raw image). This node is set by the hotplug scripts. Also clarify the usage
> of the physical-device node.
>
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Looks good to me:
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Tim Deegan <tim@xen.org>
> ---
> Changes since v2:
> - Use physical-device-path instead of physical-device in order to store the
> absolute path to the backing disk image.
> ---
> xen/include/public/io/blkif.h | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/public/io/blkif.h b/xen/include/public/io/blkif.h
> index 99f0326..ce0dbfe 100644
> --- a/xen/include/public/io/blkif.h
> +++ b/xen/include/public/io/blkif.h
> @@ -89,15 +89,23 @@
> * Values: string
> *
> * A free formatted string providing sufficient information for the
> - * backend driver to open the backing device. (e.g. the path to the
> - * file or block device representing the backing store.)
> + * hotplug script to attach the device and provide a suitable
> + * handler (ie: a block device) for blkback to use.
> *
> * physical-device
> * Values: "MAJOR:MINOR"
> + * Notes: 11
> *
> * MAJOR and MINOR are the major number and minor number of the
> * backing device respectively.
> *
> + * physical-device-path
> + * Values: path string
> + *
> + * A string that contains the absolute path to the disk image. On
> + * NetBSD and Linux this is always a block device, while on FreeBSD
> + * it can be either a block device or a regular file.
> + *
> * type
> * Values: "file", "phy", "tap"
> *
> @@ -391,6 +399,7 @@
> * than RING_SIZE * BLKIF_MAX_SEGMENTS_PER_REQUEST.
> *(10) The discard-secure property may be present and will be set to 1 if the
> * backing device supports secure discard.
> + *(11) Only used by Linux and NetBSD.
> */
>
> /*
> --
> 2.6.4 (Apple Git-63)
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-03-31 16:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 15:09 [PATCH v3 0/8] libxl: add support for FreeBSD block hotplug scripts Roger Pau Monne
2016-03-31 15:09 ` [PATCH v3 1/8] blkif: document how FreeBSD uses the physical-device backend node Roger Pau Monne
2016-03-31 16:19 ` George Dunlap [this message]
2016-04-06 14:44 ` Ian Jackson
2016-03-31 15:09 ` [PATCH v3 2/8] hotplug/FreeBSD: add block hotplug script Roger Pau Monne
2016-03-31 15:09 ` [PATCH v3 3/8] libxl: refactor the FreeBSD hotplug script code Roger Pau Monne
2016-04-06 14:45 ` Ian Jackson
2016-03-31 15:09 ` [PATCH v3 4/8] libxl: add support for disk hotplug scripts on FreeBSD Roger Pau Monne
2016-04-01 14:07 ` Ian Jackson
2016-03-31 15:09 ` [PATCH v3 5/8] libxl: properly use vdev vs local device Roger Pau Monne
2016-03-31 15:09 ` [PATCH v3 6/8] libxl: add a FreeBSD implementation of libxl__devid_to_localdev Roger Pau Monne
2016-03-31 15:09 ` [PATCH v3 7/8] libxl: fix error message in local_device_attach_cb Roger Pau Monne
2016-03-31 15:09 ` [PATCH v3 8/8] hotplug/FreeBSD: document disk hotplug interface Roger Pau Monne
2016-03-31 16:38 ` George Dunlap
2016-03-31 15:47 ` [PATCH v3 0/8] libxl: add support for FreeBSD block hotplug scripts George Dunlap
2016-03-31 16:22 ` Roger Pau Monné
2016-04-06 14:47 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFLBxZYyG+W09LsuMFA58W=y2hp5D-ro9JHrJ1S1iJga7V3g-w@mail.gmail.com' \
--to=dunlapg@umich.edu \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=roger.pau@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).