From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCFBEC433B4 for ; Mon, 10 May 2021 11:32:35 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82F35610CA for ; Mon, 10 May 2021 11:32:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82F35610CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.125155.235606 (Exim 4.92) (envelope-from ) id 1lg48x-0000XZ-Jj; Mon, 10 May 2021 11:32:11 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 125155.235606; Mon, 10 May 2021 11:32:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg48x-0000XS-Gs; Mon, 10 May 2021 11:32:11 +0000 Received: by outflank-mailman (input) for mailman id 125155; Mon, 10 May 2021 11:32:10 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lg48v-0000XM-Pf for xen-devel@lists.xenproject.org; Mon, 10 May 2021 11:32:10 +0000 Received: from desiato.infradead.org (unknown [2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id ce7f819e-ef6b-4c8f-b05a-ae2305847321; Mon, 10 May 2021 11:32:05 +0000 (UTC) Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lg48m-00E5um-VO; Mon, 10 May 2021 11:32:01 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 32B893002C4; Mon, 10 May 2021 13:32:00 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 10A7C2028F007; Mon, 10 May 2021 13:32:00 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: ce7f819e-ef6b-4c8f-b05a-ae2305847321 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=TVPjZAPijAHa4LLIWNuJ7wX5h0yLsHB88OKvBcyrgOo=; b=Gw1gDi9F8ySm9OmXtdCpTxBtJg Nq3qzu+lXQfCZfJwhi+774DevttDiMcVEwLMIXFt6kcxjVSmJKOBvR/oN1/wZk8GwzpL6opOQwnEr eWvtD1szk+xiE7MTg/c6Cd4ktFdvjdYp0YELxgAg1m2R5H4h/7/R1cLpqj6ylG3WTx1ljqIocEFuv 521+Hbg4Nb+AkVWd7EReAGd6Uq+gwPWjom7BhVcI8qV+q447UnxQ7X/JPUmtBqEUtgd4XfGQZHyk6 5XLw1M5g+Y7DFnFv6oBshdWuk/6MEJCRw5EeShxPlFUk6obt6nFHGmcIXXK5q2/Sfyp+oRlBTNwhT OnHZTXCQ==; Date: Mon, 10 May 2021 13:31:59 +0200 From: Peter Zijlstra To: Juergen Gross Cc: xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, x86@kernel.org, Boris Ostrovsky , Stefano Stabellini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" Subject: Re: [PATCH 0/3] xen: remove some checks for always present Xen features Message-ID: References: <20210422151007.2205-1-jgross@suse.com> <3c89ca14-8790-2d0e-a115-16a0976f68e3@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <3c89ca14-8790-2d0e-a115-16a0976f68e3@suse.com> On Mon, May 10, 2021 at 09:34:18AM +0200, Juergen Gross wrote: > On 22.04.21 17:10, Juergen Gross wrote: > > Some features of Xen can be assumed to be always present, so add a > > central check to verify this being true and remove the other checks. > >=20 > > Juergen Gross (3): > > xen: check required Xen features > > xen: assume XENFEAT_mmu_pt_update_preserve_ad being set for pv guests > > xen: assume XENFEAT_gnttab_map_avail_bits being set for pv guests > >=20 > > arch/x86/xen/enlighten_pv.c | 12 ++---------- > > arch/x86/xen/mmu_pv.c | 4 ++-- > > drivers/xen/features.c | 18 ++++++++++++++++++ > > drivers/xen/gntdev.c | 36 ++---------------------------------- > > 4 files changed, 24 insertions(+), 46 deletions(-) > >=20 >=20 > Could I please get some feedback on this series? I'm obviously in favour, but given I'm not an actual Xen user that might not be worth much, still: Acked-by: Peter Zijlstra (Intel)