From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 845BBC433ED for ; Tue, 11 May 2021 15:19:16 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28D7561396 for ; Tue, 11 May 2021 15:19:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28D7561396 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=citrix.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.125785.236760 (Exim 4.92) (envelope-from ) id 1lgUA0-0005uw-Pc; Tue, 11 May 2021 15:19:00 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 125785.236760; Tue, 11 May 2021 15:19:00 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgUA0-0005up-MQ; Tue, 11 May 2021 15:19:00 +0000 Received: by outflank-mailman (input) for mailman id 125785; Tue, 11 May 2021 15:18:59 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lgU9z-0005uj-NT for xen-devel@lists.xenproject.org; Tue, 11 May 2021 15:18:59 +0000 Received: from esa1.hc3370-68.iphmx.com (unknown [216.71.145.142]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 010bd790-90e9-4f7b-93d1-6ecf39dd8287; Tue, 11 May 2021 15:18:58 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 010bd790-90e9-4f7b-93d1-6ecf39dd8287 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1620746338; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=jze14czM65N3ND9Hzys2dewBaD36ReStQXcZaSi3C0w=; b=MCmBw3eXbwpvoMGbV1xIrO5hTh4PaGJBn5w9PtbWSUOzzdD804+XAnOp J6uaaFysPw9yT8J04BSjPXKck/QKcgpV1p1rb5ozX2+A+IOuxukvAGlLo wpZNBTFnnVtBdAq5YWKwePQrf/Ki1KgmRVM0v7pMUGDua0Uxsa3vUQWHP o=; Authentication-Results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none IronPort-SDR: S2mVILq5LMBUghPiJ8hIufZTUZkpE2kBGKqhBCdC45bvBgXGCsenxB7CLNhu8PhJgg6UR5m3fj 5UzMFmG68p4JXtzY364+g84f65UeW3VBszPImKXV0uyZbImbgLj8344JfsKoRm538ywycJ010S wtsa4nJCjXfcmEfHbiqbfNjEIWkZ8IagWx3nySYRJLk3DufSBIniK5TMdTM5PpHwcQmctwWgu6 +0u+IIWw8/sLSiq8hPUuC5h6RXUBoU096Fly351wmqXMJx9wPvzbYo0HqXwDXcGAUzSYbsUiPy gys= X-SBRS: 5.1 X-MesageID: 43935543 X-Ironport-Server: esa1.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED IronPort-HdrOrdr: A9a23:kq9hF6ryfWJjgxxiF5W9TNkaV5oheYIsimQD101hICG9Ffbo8v xG/c5rtyMc5wx8ZJhNo7+90cq7MBDhHPxOgLX5VI3KNGOKhILBFvAH0WKI+V3d8kPFmNK0is xbGJSWoueAamRHsQ== X-IronPort-AV: E=Sophos;i="5.82,291,1613451600"; d="scan'208";a="43935543" Date: Tue, 11 May 2021 16:18:55 +0100 From: Anthony PERARD To: Julien Grall CC: , Julien Grall , Ian Jackson , Wei Liu Subject: Re: [PATCH 09/14] tools/console: Use const whenever we point to literal strings Message-ID: References: <20210405155713.29754-1-julien@xen.org> <20210405155713.29754-10-julien@xen.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210405155713.29754-10-julien@xen.org> On Mon, Apr 05, 2021 at 04:57:08PM +0100, Julien Grall wrote: > From: Julien Grall > > literal strings are not meant to be modified. So we should use const > char * rather than char * when we want to store a pointer to them. > > Signed-off-by: Julien Grall > --- > diff --git a/tools/console/daemon/io.c b/tools/console/daemon/io.c > index 4af27ffc5d02..6a8a94e31b65 100644 > --- a/tools/console/daemon/io.c > +++ b/tools/console/daemon/io.c > @@ -109,9 +109,9 @@ struct console { > }; > > struct console_type { > - char *xsname; > - char *ttyname; > - char *log_suffix; > + const char *xsname; I think that const of `xsname` is lost in console_init() in the same file. We have: static int console_init(.. ) { struct console_type **con_type = (struct console_type **)data; char *xsname, *xspath; xsname = (char *)(*con_type)->xsname; } So constify "xsname" in console_init() should be part of the patch, I think. Thanks, -- Anthony PERARD