From: Nick Rosbrook <rosbrookn@gmail.com>
To: George Dunlap <George.Dunlap@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Nick Rosbrook <rosbrookn@ainfosec.com>,
Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [RESEND PATCH 00/12] golang/xenlight: domain life cycle support
Date: Mon, 21 Jun 2021 12:19:31 -0400 [thread overview]
Message-ID: <YNC8E1wwSG54RVzC@FED-nrosbr-BE.crux.rad.ainfosec.com> (raw)
In-Reply-To: <AD0B1F68-3FAE-4F3C-BCF5-9623A76A0A9B@citrix.com>
On Mon, Jun 21, 2021 at 03:53:39PM +0000, George Dunlap wrote:
>
>
> > On May 24, 2021, at 9:36 PM, Nick Rosbrook <rosbrookn@gmail.com> wrote:
> >
> > The primary goal of this patch series is to allow users of the xenlight
> > package to manage a full domain life cycle. In particular, it provides
> > support for receiving domain death events so that domain shutdown,
> > reboot, destroy, etc. can be handled. And, it addresses issues found
> > when using the package to boot domains with various configurations.
> >
> > These patches address several things (e.g. bug fixes, code style,
> > conveniences, new wrapper functions), but are all work towards the final
> > goal of allowing a package user to manage a full domain life cycle.
> >
> > Nick Rosbrook (12):
>
> OK, I’ve checked in the following patches: (1, 2, 4, 5, 6, 9, 10, 11):
>
> > golang/xenlight: update generated code
> > golang/xenlight: fix StringList toC conversion
> > golang/xenlight: export keyed union interface types
> > golang/xenlight: use struct pointers in keyed union fields
> > golang/xenlight: rename Ctx receivers to ctx
>
> > golang/xenlight: add DomainDestroy wrapper
> > golang/xenlight: add SendTrigger wrapper
> > golang/xenlight: do not negate ret when converting to Error
>
> The following have not been checked in due outsanding review comments (patches 3, 7, 12), or because they depend on a patch not being checked in (patch 8):
>
> > golang/xenlight: fix string conversion in generated toC functions
> > golang/xenlight: add logging conveniences for within xenlight
> > golang/xenlight: add functional options to configure Context
> > golang/xenlight: add NotifyDomainDeath method to Context
>
Thanks! I am planning on addressing patch 12 comments later today.
-NR
prev parent reply other threads:[~2021-06-21 16:19 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 20:36 [RESEND PATCH 00/12] golang/xenlight: domain life cycle support Nick Rosbrook
2021-05-24 20:36 ` [RESEND PATCH 01/12] golang/xenlight: update generated code Nick Rosbrook
2021-06-18 10:30 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 02/12] golang/xenlight: fix StringList toC conversion Nick Rosbrook
2021-06-18 10:51 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 03/12] golang/xenlight: fix string conversion in generated toC functions Nick Rosbrook
2021-06-18 11:00 ` George Dunlap
2021-06-21 16:11 ` Nick Rosbrook
2021-07-01 14:09 ` George Dunlap
2021-07-07 19:29 ` Nick Rosbrook
2021-05-24 20:36 ` [RESEND PATCH 04/12] golang/xenlight: export keyed union interface types Nick Rosbrook
2021-06-18 11:19 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 05/12] golang/xenlight: use struct pointers in keyed union fields Nick Rosbrook
2021-06-18 11:26 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 06/12] golang/xenlight: rename Ctx receivers to ctx Nick Rosbrook
2021-06-18 11:39 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 07/12] golang/xenlight: add logging conveniences for within xenlight Nick Rosbrook
2021-06-18 13:17 ` George Dunlap
2021-06-18 13:21 ` George Dunlap
2021-06-18 15:26 ` Nick Rosbrook
2021-06-18 16:30 ` George Dunlap
2021-06-18 15:17 ` Nick Rosbrook
2021-06-18 16:28 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 08/12] golang/xenlight: add functional options to configure Context Nick Rosbrook
2021-06-18 14:44 ` George Dunlap
2021-06-18 15:08 ` Nick Rosbrook
2021-06-18 16:18 ` George Dunlap
2021-06-18 17:00 ` Nick Rosbrook
2021-06-18 18:12 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 09/12] golang/xenlight: add DomainDestroy wrapper Nick Rosbrook
2021-06-18 14:47 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 10/12] golang/xenlight: add SendTrigger wrapper Nick Rosbrook
2021-06-18 14:54 ` George Dunlap
2021-05-24 20:36 ` [RESEND PATCH 11/12] golang/xenlight: do not negate ret when converting to Error Nick Rosbrook
2021-06-18 15:13 ` George Dunlap
2021-06-18 15:32 ` Nick Rosbrook
2021-05-24 20:36 ` [RESEND PATCH 12/12] golang/xenlight: add NotifyDomainDeath method to Context Nick Rosbrook
2021-06-18 18:28 ` George Dunlap
2021-06-18 19:31 ` George Dunlap
2021-06-21 21:41 ` Nick Rosbrook
2021-06-17 15:29 ` [RESEND PATCH 00/12] golang/xenlight: domain life cycle support Nick Rosbrook
2021-06-21 15:53 ` George Dunlap
2021-06-21 16:19 ` Nick Rosbrook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNC8E1wwSG54RVzC@FED-nrosbr-BE.crux.rad.ainfosec.com \
--to=rosbrookn@gmail.com \
--cc=George.Dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=rosbrookn@ainfosec.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).