From: Juergen Gross <jgross@suse.com>
To: xen-devel@lists.xenproject.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: rppt@linux.ibm.com,
Alexander Duyck <alexander.h.duyck@linux.intel.com>,
Michal Hocko <mhocko@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
pasha.tatashin@soleen.com
Subject: Re: [Xen-devel] [PATCH] mm: fix regression with deferred struct page init
Date: Thu, 27 Jun 2019 17:35:39 +0200 [thread overview]
Message-ID: <a9b02905-8b4f-48ac-8638-8ff99bd3b0e6@suse.com> (raw)
In-Reply-To: <79797c17-58d6-b09c-3aad-73e375a7f208@suse.com>
On 25.06.19 10:25, Juergen Gross wrote:
> Gentle ping.
>
> I'd really like to have that in 5.2 in order to avoid the regression
> introduced with 5.2-rc1.
Adding some maintainers directly...
Juergen
>
>
> Juergen
>
> On 20.06.19 18:08, Juergen Gross wrote:
>> Commit 0e56acae4b4dd4a9 ("mm: initialize MAX_ORDER_NR_PAGES at a time
>> instead of doing larger sections") is causing a regression on some
>> systems when the kernel is booted as Xen dom0.
>>
>> The system will just hang in early boot.
>>
>> Reason is an endless loop in get_page_from_freelist() in case the first
>> zone looked at has no free memory. deferred_grow_zone() is always
>> returning true due to the following code snipplet:
>>
>> /* If the zone is empty somebody else may have cleared out the zone */
>> if (!deferred_init_mem_pfn_range_in_zone(&i, zone, &spfn, &epfn,
>> first_deferred_pfn)) {
>> pgdat->first_deferred_pfn = ULONG_MAX;
>> pgdat_resize_unlock(pgdat, &flags);
>> return true;
>> }
>>
>> This in turn results in the loop as get_page_from_freelist() is
>> assuming forward progress can be made by doing some more struct page
>> initialization.
>>
>> Cc: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>> Fixes: 0e56acae4b4dd4a9 ("mm: initialize MAX_ORDER_NR_PAGES at a time
>> instead of doing larger sections")
>> Suggested-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> ---
>> mm/page_alloc.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
>> index d66bc8abe0af..8e3bc949ebcc 100644
>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -1826,7 +1826,8 @@ deferred_grow_zone(struct zone *zone, unsigned
>> int order)
>> first_deferred_pfn)) {
>> pgdat->first_deferred_pfn = ULONG_MAX;
>> pgdat_resize_unlock(pgdat, &flags);
>> - return true;
>> + /* Retry only once. */
>> + return first_deferred_pfn != ULONG_MAX;
>> }
>> /*
>>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-06-27 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 16:08 [Xen-devel] [PATCH] mm: fix regression with deferred struct page init Juergen Gross
2019-06-20 16:10 ` Alexander Duyck
2019-06-25 8:25 ` Juergen Gross
2019-06-27 15:35 ` Juergen Gross [this message]
2019-06-28 15:17 ` Michal Hocko
2019-06-28 17:38 ` Juergen Gross
2019-06-28 18:47 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9b02905-8b4f-48ac-8638-8ff99bd3b0e6@suse.com \
--to=jgross@suse.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=pasha.tatashin@soleen.com \
--cc=rppt@linux.ibm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).