From: Stefano Stabellini <sstabellini@kernel.org>
To: David Vrabel <dvrabel@cantab.net>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
linux-kernel@vger.kernel.org,
David Vrabel <david.vrabel@citrix.com>,
xen-devel@lists.xenproject.org,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
rt@linutronix.de
Subject: Re: [PATCH] xen: Add comment for missing FROZEN notifier transitions
Date: Wed, 6 Apr 2016 16:53:54 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.10.1604061652410.31453__34855.1831710667$1459986907$gmane$org@sstabellini-ThinkPad-X230> (raw)
In-Reply-To: <57050A98.80901@cantab.net>
On Wed, 6 Apr 2016, David Vrabel wrote:
> On 04/04/16 13:32, Anna-Maria Gleixner wrote:
> > Xen guests do not offline/online CPUs during suspend/resume and
> > therefore FROZEN notifier transitions are not required. Add this
> > explanation as a comment in the code to get not confused why
> > CPU_TASKS_FROZEN masked transitions are not considered.
> >
> > Cc: David Vrabel <david.vrabel@citrix.com>
> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> > Cc: xen-devel@lists.xenproject.org
> > Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
> > ---
> > arch/arm/xen/enlighten.c | 6 ++++++
> > arch/x86/xen/enlighten.c | 7 +++++++
> > drivers/xen/events/events_fifo.c | 6 ++++++
> > 3 files changed, 19 insertions(+)
> >
> > --- a/arch/arm/xen/enlighten.c
> > +++ b/arch/arm/xen/enlighten.c
> > @@ -213,6 +213,12 @@ static int xen_cpu_notification(struct n
> > unsigned long action,
> > void *hcpu)
> > {
> > + /*
> > + * Xen guests do not offline/online CPUs during
> > + * suspend/resume, thus CPU_TASKS_FROZEN masked transitions
> > + * are not considered.
> > + */
>
> This may not be true for arm guests.
ARM guests behave like x86 PV guests in this regard. I expect the
comment to be appropriate for both archs or none.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-06 23:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1459773140-43707-1-git-send-email-anna-maria@linutronix.de>
2016-04-04 16:21 ` [PATCH] xen: Add comment for missing FROZEN notifier transitions Julien Grall
[not found] ` <57029499.7070007@arm.com>
2016-04-04 16:30 ` David Vrabel
[not found] ` <570296C3.70805@citrix.com>
2016-04-04 16:48 ` Boris Ostrovsky
[not found] ` <57029AC7.90201@oracle.com>
2016-04-05 4:22 ` Juergen Gross
[not found] ` <57033D78.8010306@suse.com>
2016-04-06 23:52 ` Stefano Stabellini
2016-04-06 13:09 ` David Vrabel
[not found] ` <57050A98.80901@cantab.net>
2016-04-06 14:08 ` [PREEMPT-RT] " Anna-Maria Gleixner
2016-04-06 23:53 ` Stefano Stabellini [this message]
2016-04-04 12:32 Anna-Maria Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='alpine.DEB.2.10.1604061652410.31453__34855.1831710667$1459986907$gmane$org@sstabellini-ThinkPad-X230' \
--to=sstabellini@kernel.org \
--cc=anna-maria@linutronix.de \
--cc=david.vrabel@citrix.com \
--cc=dvrabel@cantab.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rt@linutronix.de \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).