From: Stefano Stabellini <sstabellini@kernel.org>
To: Shanker Donthineni <shankerd@codeaurora.org>
Cc: Philip Elcan <pelcan@codeaurora.org>,
Vikram Sethi <vikrams@codeaurora.org>,
Andre Przywara <andre.przywara@arm.com>,
Julien Grall <julien.grall@arm.com>,
xen-devel <xen-devel@lists.xensource.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Wei Chen <wei.chen@linaro.org>
Subject: Re: [PATCH V9 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS
Date: Mon, 13 Jun 2016 11:30:05 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.10.1606131129020.2878@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <1465493601-15182-2-git-send-email-shankerd@codeaurora.org>
On Thu, 9 Jun 2016, Shanker Donthineni wrote:
> The Masked interrupt status register (UARTMIS) is not described in ARM
> SBSA 2.x document. Anding of two registers UARTMSC and UARTRIS values
> gives the same information as register UARTMIS.
>
> UARTRIS, UARTMSC and UARTMIS definitions are found in PrimeCell UART
> PL011 (Revision: r1p4).
> - 3.3.10 Interrupt mask set/clear register, UARTIMSC
> - 3.3.11 Raw interrupt status register, UARTRIS
> - 3.3.12 Masked interrupt status register, UARTMIS
>
> This change is necessary for driver to be SBSA compliant v2.x without
> affecting the current driver functionality.
>
> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
>
> Changes since v8:
> Fixed white spaces.
>
> Changes since v7:
> Moved comment 'To compatible with SBSA v2.x document, all accesses should be 32-bit' to #3
>
> Changes since v1:
> Added a new function to return an interrupt status.
>
> xen/drivers/char/pl011.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c
> index 6a3c21b..7e19c4a 100644
> --- a/xen/drivers/char/pl011.c
> +++ b/xen/drivers/char/pl011.c
> @@ -53,11 +53,17 @@ static struct pl011 {
> #define pl011_read(uart, off) readl((uart)->regs + (off))
> #define pl011_write(uart, off,val) writel((val), (uart)->regs + (off))
>
> +static unsigned int pl011_intr_status(struct pl011 *uart)
Maybe this should be static inline?
In any case the series is good, I am happy to queue it up for 4.8.
> +{
> + /* UARTMIS is not documented in SBSA v2.x, so use UARTRIS/UARTIMSC. */
> + return (pl011_read(uart, RIS) & pl011_read(uart, IMSC));
> +}
> +
> static void pl011_interrupt(int irq, void *data, struct cpu_user_regs *regs)
> {
> struct serial_port *port = data;
> struct pl011 *uart = port->uart;
> - unsigned int status = pl011_read(uart, MIS);
> + unsigned int status = pl011_intr_status(uart);
>
> if ( status )
> {
> @@ -76,7 +82,7 @@ static void pl011_interrupt(int irq, void *data, struct cpu_user_regs *regs)
> if ( status & (TXI) )
> serial_tx_interrupt(port, regs);
>
> - status = pl011_read(uart, MIS);
> + status = pl011_intr_status(uart);
> } while (status != 0);
> }
> }
> --
> Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-06-13 10:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 17:33 [PATCH V9 1/3] drivers/pl011: Don't configure baudrate Shanker Donthineni
2016-06-09 17:33 ` [PATCH V9 2/3] drivers/pl011: Use combination of UARTRIS and UARTMSC instead of UARTMIS Shanker Donthineni
2016-06-13 10:30 ` Stefano Stabellini [this message]
2016-06-13 17:43 ` Shanker Donthineni
2016-06-14 14:53 ` Julien Grall
2016-06-09 17:33 ` [PATCH V9 3/3] arm/acpi: Add Server Base System Architecture UART support Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1606131129020.2878@sstabellini-ThinkPad-X260 \
--to=sstabellini@kernel.org \
--cc=andre.przywara@arm.com \
--cc=julien.grall@arm.com \
--cc=pelcan@codeaurora.org \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
--cc=wei.chen@linaro.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).