From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr_Babchuk@epam.com
Subject: Re: [Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func
Date: Wed, 14 Aug 2019 15:54:00 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1908141552330.8737@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <ff2917ae-6b02-12b9-a420-f069a767238b@arm.com>
On Tue, 13 Aug 2019, Julien Grall wrote:
> On 8/12/19 11:28 PM, Stefano Stabellini wrote:
> > Change the signature of process_memory_node to match
> > device_tree_node_func. Thanks to this change, the next patch will be
> > able to use device_tree_for_each_node to call process_memory_node on all
> > the children of a provided node.
> >
> > Return error if there is no reg property or if nr_banks is reached. Let
> > the caller deal with the error.
> >
> > Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> > ---
> > Changes in v5:
> > - return -ENOENT if address_cells or size_cells are not properly set
> >
> > Changes in v4:
> > - return error if there is no reg propery, remove printk
> > - return error if nr_banks is reached
> >
> > Changes in v3:
> > - improve commit message
> > - check return value of process_memory_node
> >
> > Changes in v2:
> > - new
> > ---
> > xen/arch/arm/bootfdt.c | 29 +++++++++++++++--------------
> > 1 file changed, 15 insertions(+), 14 deletions(-)
> >
> > diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> > index a872ea57d6..590b14304c 100644
> > --- a/xen/arch/arm/bootfdt.c
> > +++ b/xen/arch/arm/bootfdt.c
> > @@ -125,9 +125,10 @@ int __init device_tree_for_each_node(const void *fdt,
> > int node,
> > return 0;
> > }
> > -static void __init process_memory_node(const void *fdt, int node,
> > - const char *name,
> > - u32 address_cells, u32 size_cells)
> > +static int __init process_memory_node(const void *fdt, int node,
> > + const char *name, int depth,
> > + u32 address_cells, u32 size_cells,
> > + void *data)
> > {
> > const struct fdt_property *prop;
> > int i;
> > @@ -137,18 +138,11 @@ static void __init process_memory_node(const void
> > *fdt, int node,
> > u32 reg_cells = address_cells + size_cells;
> > if ( address_cells < 1 || size_cells < 1 )
> > - {
> > - printk("fdt: node `%s': invalid #address-cells or #size-cells",
> > - name);
> > - return;
> > - }
> > + return -ENOENT;
>
> I saw your answer on the previous version and didn't get the chance. Missing
> the "regs" property and wrong {address,size}-cells values are two different
> things.
>
> In the former case, it just means the reserved-region will be allocated
> dynamically.
>
> In the latter case, this is an error in the device-tree configuration. If you
> ignore it, you are at risk to not take into account a reserved-region.
>
> I agree this is a bug in the Device-Tree, but doing basic sanity check for the
> users is always helpful.
>
> With that in mind, I would keep the printk and return a different error here.
OK. I'll use -EINVAL for this case, and keep the printk.
> > prop = fdt_get_property(fdt, node, "reg", NULL);
> > if ( !prop )
> > - {
> > - printk("fdt: node `%s': missing `reg' property\n", name);
> > - return;
> > - }
> > + return -ENOENT;
> > cell = (const __be32 *)prop->data;
> > banks = fdt32_to_cpu(prop->len) / (reg_cells * sizeof (u32));
> > @@ -162,6 +156,10 @@ static void __init process_memory_node(const void *fdt,
> > int node,
> > bootinfo.mem.bank[bootinfo.mem.nr_banks].size = size;
> > bootinfo.mem.nr_banks++;
> > }
> > +
> > + if ( bootinfo.mem.nr_banks == NR_MEM_BANKS )
> > + return -ENOSPC;
> > + return 0;
> > }
> > static void __init process_multiboot_node(const void *fdt, int node,
> > @@ -293,15 +291,18 @@ static int __init early_scan_node(const void *fdt,
> > u32 address_cells, u32 size_cells,
> > void *data)
> > {
> > + int rc = 0;
> > +
> > if ( device_tree_node_matches(fdt, node, "memory") )
> > - process_memory_node(fdt, node, name, address_cells, size_cells);
> > + rc = process_memory_node(fdt, node, name, depth,
> > + address_cells, size_cells, NULL);
>
> As a small NIT there are no way for the user to know that the parsing failed
> because of the reg property were missing. Could you print an error message
> either here or maybe in device_tree_for_each() to say parsing as failed for
> node N?
I'll add a new printk at the end of early_scan_node
> > else if ( depth <= 3 && (device_tree_node_compatible(fdt, node,
> > "xen,multiboot-module" ) ||
> > device_tree_node_compatible(fdt, node, "multiboot,module"
> > )))
> > process_multiboot_node(fdt, node, name, address_cells,
> > size_cells);
> > else if ( depth == 1 && device_tree_node_matches(fdt, node, "chosen")
> > )
> > process_chosen_node(fdt, node, name, address_cells, size_cells);
> > - return 0;
> > + return rc;
> > }
> > static void __init early_print_info(void)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-08-14 22:54 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 22:28 [Xen-devel] [PATCH v5 0/7] reserved-memory in dom0 Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 1/7] xen/arm: pass node to device_tree_for_each_node Stefano Stabellini
2019-08-13 13:45 ` Volodymyr Babchuk
2019-08-14 22:12 ` Stefano Stabellini
2019-08-13 17:25 ` Julien Grall
2019-08-14 22:11 ` Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 2/7] xen/arm: make process_memory_node a device_tree_node_func Stefano Stabellini
2019-08-13 14:14 ` Volodymyr Babchuk
2019-08-14 22:35 ` Stefano Stabellini
2019-08-15 9:12 ` Julien Grall
2019-08-15 11:20 ` Volodymyr Babchuk
2019-08-15 11:24 ` Julien Grall
2019-08-15 11:29 ` Julien Grall
2019-08-15 12:14 ` Volodymyr Babchuk
2019-08-15 12:33 ` Julien Grall
2019-08-15 13:51 ` Volodymyr Babchuk
2019-08-15 14:15 ` Julien Grall
2019-08-13 17:37 ` Julien Grall
2019-08-14 22:54 ` Stefano Stabellini [this message]
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 3/7] xen/arm: keep track of reserved-memory regions Stefano Stabellini
2019-08-13 14:23 ` Volodymyr Babchuk
2019-08-13 14:46 ` Julien Grall
2019-08-13 15:14 ` Volodymyr Babchuk
2019-08-13 15:15 ` Julien Grall
2019-08-13 15:39 ` Volodymyr Babchuk
2019-08-14 12:48 ` Julien Grall
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 4/7] xen/arm: early_print_info print reserved_mem Stefano Stabellini
2019-08-13 14:28 ` Volodymyr Babchuk
2019-08-13 14:47 ` Julien Grall
2019-08-14 22:21 ` Stefano Stabellini
2019-08-14 12:52 ` Julien Grall
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 5/7] xen/arm: handle reserved-memory in consider_modules and dt_unreserved_regions Stefano Stabellini
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 6/7] xen/arm: don't iomem_permit_access for reserved-memory regions Stefano Stabellini
2019-08-13 14:34 ` Volodymyr Babchuk
2019-08-13 14:55 ` Julien Grall
2019-08-14 22:40 ` Stefano Stabellini
2019-08-15 9:15 ` Julien Grall
2019-08-12 22:28 ` [Xen-devel] [PATCH v5 7/7] xen/arm: add reserved-memory regions to the dom0 memory node Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1908141552330.8737@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=julien.grall@arm.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).