From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [PATCH] xen/arm: Warn user on cpu errata 832075
Date: Wed, 14 Oct 2020 14:15:47 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.2010141350170.10386@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <f49d478f-4efe-955e-c378-f2fa5fbc6a71@xen.org>
On Wed, 14 Oct 2020, Julien Grall wrote:
> On 14/10/2020 17:03, Bertrand Marquis wrote:
> > > On 14 Oct 2020, at 12:35, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> > >
> > > On 14/10/2020 11:41, Bertrand Marquis wrote:
> > > > When a Cortex A57 processor is affected by CPU errata 832075, a guest
> > > > not implementing the workaround for it could deadlock the system.
> > > > Add a warning during boot informing the user that only trusted guests
> > > > should be executed on the system.
> > > > An equivalent warning is already given to the user by KVM on cores
> > > > affected by this errata.
> > > >
> > > > Signed-off-by: Bertrand Marquis <bertrand.marquis@arm.com>
> > > > ---
> > > > xen/arch/arm/cpuerrata.c | 21 +++++++++++++++++++++
> > > > 1 file changed, 21 insertions(+)
> > > >
> > > > diff --git a/xen/arch/arm/cpuerrata.c b/xen/arch/arm/cpuerrata.c
> > > > index 6c09017515..8f9ab6dde1 100644
> > > > --- a/xen/arch/arm/cpuerrata.c
> > > > +++ b/xen/arch/arm/cpuerrata.c
> > > > @@ -240,6 +240,26 @@ static int enable_ic_inv_hardening(void *data)
> > > >
> > > > #endif
> > > >
> > > > +#ifdef CONFIG_ARM64_ERRATUM_832075
> > > > +
> > > > +static int warn_device_load_acquire_errata(void *data)
> > > > +{
> > > > + static bool warned = false;
> > > > +
> > > > + if ( !warned )
> > > > + {
> > > > + warning_add("This CPU is affected by the errata 832075.\n"
> > > > + "Guests without required CPU erratum workarounds\n"
> > > > + "can deadlock the system!\n"
> > > > + "Only trusted guests should be used on this
> > > > system.\n");
> > > > + warned = true;
> > >
> > > This is an antipattern, which probably wants fixing elsewhere as well.
> > >
> > > warning_add() is __init. It's not legitimate to call from a non-init
> > > function, and a less useless build system would have modpost to object.
> > >
> > > The ARM_SMCCC_ARCH_WORKAROUND_1 instance asserts based on system state,
> > > but this provides no safety at all.
> > >
> > >
> > > What warning_add() actually does is queue messages for some point near
> > > the end of boot. It's not clear that this is even a clever thing to do.
> > >
> > > I'm very tempted to suggest a blanket change to printk_once().
> >
> > If this is needed then this could be done in an other serie ?
>
> The callback ->enable() will be called when a CPU is onlined/offlined. So this
> is going to require if you plan to support CPU hotplugs or suspend resume.
>
> > Would be good to keep this patch as purely handling the errata.
My preference would be to keep this patch small with just the errata,
maybe using a simple printk_once as Andrew and Julien discussed.
There is another instance of warning_add potentially being called
outside __init in xen/arch/arm/cpuerrata.c:
enable_smccc_arch_workaround_1. So if you are up for it, it would be
good to produce a patch to fix that too.
> In the case of this patch, how about moving the warning_add() in
> enable_errata_workarounds()?
>
> By then we should now all the errata present on your platform. All CPUs
> onlined afterwards (i.e. runtime) should always abide to the set discover
> during boot.
If I understand your suggestion correctly, it would work for
warn_device_load_acquire_errata, because it is just a warning, but it
would not work for enable_smccc_arch_workaround_1, because there is
actually a call to be made there.
Maybe it would be simpler to use printk_once in both cases? I don't have
a strong preference either way.
next prev parent reply other threads:[~2020-10-14 21:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 10:41 [PATCH] xen/arm: Warn user on cpu errata 832075 Bertrand Marquis
2020-10-14 11:11 ` Julien Grall
2020-10-14 16:00 ` Bertrand Marquis
2020-10-14 20:46 ` Stefano Stabellini
2020-10-14 11:35 ` Andrew Cooper
2020-10-14 16:03 ` Bertrand Marquis
2020-10-14 17:22 ` Julien Grall
2020-10-14 21:15 ` Stefano Stabellini [this message]
2020-10-15 10:10 ` Bertrand Marquis
2020-10-15 18:05 ` Stefano Stabellini
2020-10-21 9:03 ` Julien Grall
2020-10-21 9:44 ` Bertrand Marquis
2020-10-21 9:46 ` Julien Grall
2020-10-21 9:52 ` Bertrand Marquis
2020-10-14 17:13 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2010141350170.10386@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Bertrand.Marquis@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).