Re: [Xen-devel] [livepatch: independ. modules v2 2/3] livepatch: Allow to override inter-modules buildid dependency

From: Julien Grall <julien.grall@arm.com>
To: "Wieczorkiewicz, Pawel" <wipawel@amazon.de>
Cc: Tim Deegan <tim@xen.org>,
	Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel <xen-devel@lists.xen.org>,
	"Pohlack, Martin" <mpohlack@amazon.de>,
	Ross Lagerwall <ross.lagerwall@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] [livepatch: independ. modules v2 2/3] livepatch: Allow to override inter-modules buildid dependency
Date: Tue, 20 Aug 2019 15:28:30 +0100	[thread overview]
Message-ID: <c6b76dbd-bf18-aa66-0e55-84b9adedb45a@arm.com> (raw)
In-Reply-To: <CB3FCDBE-6DD1-4F17-B106-AE26E478AB74@amazon.com>

Hi,

On 20/08/2019 15:09, Wieczorkiewicz, Pawel wrote:
> 
>> On 20. Aug 2019, at 15:35, Julien Grall <julien.grall@arm.com> wrote:
>>
>> Hi,
>>
>> Something looks fishy in the threading:
>>
>>   - The patch #1 is answered in reply-to the patch #1 of version 1.
>>   - This patch (#2) is answered in reply-to the patch #2 of version 1.
>>   - The patch #3 is labeled as v3 an in reply-to the patch #3 of version 1.
>>
>> If you send them as series, then they should be sent together for a new version and in a new thread. Not mangled to the previous thread as this makes quite difficult to follow what's going on.
>>
>> Also it looks like the series is still lacking of the cover letter. So I still have no clue what "livepatch: independ. modules" in your [...] refers to.
>>
> 
> Yeah, since I got feedback and reviews on various patches that I have already submitted the way I did,
> I simply continue with what I have until all comments are addressed (I do not want to lose anything).

What do you mean by "all comments are addressed"? Usually you gather a set of 
comments for a series, address them and then resend the series with all of them 
addressed.

> 
> Then, I will re-send the patches in 2 series: livepatch-build-tools and xen with all changes,
> Reviewed-by/Acked-by and cover letters. This is the way recommended by Andrew.

Please don't send the patch one by one to check if everyone is happy. Just 
resend all of them in one go once you gathered enough feedback.

> 
> Unfortunately, it will be also quite confusing I think, because various changes belonging to different topics,
> are distributed between those 2 distinct repos.

That also happen when you have multiple patches in a series. Feature implemented 
accross multiple patch needs a place to discuss. This can usually be done in the 
cover letter. For multi repo series, you can steer the discussion on a single 
repo and just replicate the changes in the other one once there are an agreement.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel