xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Julien Grall <julien@xen.org>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Stefano Stabellini <sstabellini@kernel.org>,
	Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [XEN PATCH v3 1/2] xen/arm: Rename all early printk macro
Date: Thu, 12 Mar 2020 20:18:00 +0000	[thread overview]
Message-ID: <ce6e22a2-e9a5-8cf7-b91a-3bd1efe33859@xen.org> (raw)
In-Reply-To: <20200311144631.GI2152@perard.uk.xensource.com>

Hi,

On 11/03/2020 14:46, Anthony PERARD wrote:
> On Wed, Mar 11, 2020 at 01:57:37PM +0000, Julien Grall wrote:
>> Hi Anthony,
>>
>> On 09/03/2020 17:45, Anthony PERARD wrote:
>>> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
>>> index e9d356f05c2b..2b593c5ef99a 100644
>>> --- a/xen/arch/arm/arm32/head.S
>>> +++ b/xen/arch/arm/arm32/head.S
>>> @@ -36,8 +36,8 @@
>>>    #define XEN_FIRST_SLOT      first_table_offset(XEN_VIRT_START)
>>>    #define XEN_SECOND_SLOT     second_table_offset(XEN_VIRT_START)
>>> -#if (defined (CONFIG_EARLY_PRINTK)) && (defined (EARLY_PRINTK_INC))
>>> -#include EARLY_PRINTK_INC
>>> +#if (defined (CONFIG_EARLY_PRINTK)) && (defined (CONFIG_EARLY_PRINTK_INC))
>>
>> NIT: I would also take the opportunity to clean-up the line by remove the
>> extra () and the space before (. Something like:
>>
>> #if define(CONFIG_EARLY_PRINTK) && defined(CONFIG_EARLY_PRINTK_INC)
>>
>> [...]
>>
>>> diff --git a/xen/arch/arm/arm64/head.S b/xen/arch/arm/arm64/head.S
>>> index e5015f93a2d8..4d45ea3dac3c 100644
>>> --- a/xen/arch/arm/arm64/head.S
>>> +++ b/xen/arch/arm/arm64/head.S
>>> @@ -45,8 +45,8 @@
>>>    #define __HEAD_FLAGS            ((__HEAD_FLAG_PAGE_SIZE << 1) | \
>>>                                     (__HEAD_FLAG_PHYS_BASE << 3))
>>> -#if (defined (CONFIG_EARLY_PRINTK)) && (defined (EARLY_PRINTK_INC))
>>> -#include EARLY_PRINTK_INC
>>> +#if (defined (CONFIG_EARLY_PRINTK)) && (defined (CONFIG_EARLY_PRINTK_INC))
>>
>> Same here.
> 
> Those clean-up sounds good.

I will give a couple of days so Stefano can have an opportunity to 
comment. If I don't hear anything by Monday, I will commit it.

> 
>> I am happy to fix both cases on commit:
>>
>> Acked-by: Julien Grall <jgrall@amazon.com>
> 
> Thanks,
> 

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2020-03-12 20:18 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 17:45 [Xen-devel] [XEN PATCH v3 0/2] xen/arm: Configure early printk via Kconfig Anthony PERARD
2020-03-09 17:45 ` [Xen-devel] [XEN PATCH v3 1/2] xen/arm: Rename all early printk macro Anthony PERARD
2020-03-11 13:57   ` Julien Grall
2020-03-11 14:46     ` Anthony PERARD
2020-03-12 20:18       ` Julien Grall [this message]
2020-03-13 23:01         ` Stefano Stabellini
2020-03-09 17:45 ` [Xen-devel] [XEN PATCH v3 2/2] xen/arm: Configure early printk via Kconfig Anthony PERARD
2020-03-11 14:18   ` Julien Grall
     [not found]     ` <20200311152613.GJ2152@perard.uk.xensource.com>
2020-03-11 17:21       ` Julien Grall
2020-03-11 17:38         ` Anthony PERARD
2020-03-12 20:16           ` Julien Grall
2020-03-13 23:12   ` Stefano Stabellini
2020-03-13 23:14     ` Stefano Stabellini
2020-03-17  9:36       ` Julien Grall
2020-03-17 17:51         ` Stefano Stabellini
2020-03-24 14:48           ` Anthony PERARD
2020-03-13 23:19     ` Julien Grall
2020-03-13 23:37       ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ce6e22a2-e9a5-8cf7-b91a-3bd1efe33859@xen.org \
    --to=julien@xen.org \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=anthony.perard@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).