From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63A44C388F7 for ; Fri, 13 Nov 2020 11:20:59 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EEF9F207DE for ; Fri, 13 Nov 2020 11:20:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="dWJ1cu8+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EEF9F207DE Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.26384.54699 (Exim 4.92) (envelope-from ) id 1kdX8A-0008SQ-QH; Fri, 13 Nov 2020 11:20:38 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 26384.54699; Fri, 13 Nov 2020 11:20:38 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdX8A-0008SJ-Mk; Fri, 13 Nov 2020 11:20:38 +0000 Received: by outflank-mailman (input) for mailman id 26384; Fri, 13 Nov 2020 11:20:37 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdX89-0008SE-R2 for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 11:20:37 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 43b4a371-7853-4d07-983d-c36a34d06fc4; Fri, 13 Nov 2020 11:20:36 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DDECAAEFB; Fri, 13 Nov 2020 11:20:34 +0000 (UTC) Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kdX89-0008SE-R2 for xen-devel@lists.xenproject.org; Fri, 13 Nov 2020 11:20:37 +0000 X-Inumbo-ID: 43b4a371-7853-4d07-983d-c36a34d06fc4 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 43b4a371-7853-4d07-983d-c36a34d06fc4; Fri, 13 Nov 2020 11:20:36 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1605266435; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TLQ9FVom6R6KKOTePpK0JU7y8/s9rbU+RkGF1j+/oRQ=; b=dWJ1cu8+k+o7bhRvIQwO188OTvg/oK7KFot9HskOrlTJ4bKbTWOcKQbi45d9/fgOWqboUI gQrelVR5VvWyD12hr8LFNVLjh4v86BNCKE+QD+TWvw1I8SnwFOgcN/xQVWJmk723yVAneh aQvHzUkVPDeL7mlzgKtismHKYMns82E= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id DDECAAEFB; Fri, 13 Nov 2020 11:20:34 +0000 (UTC) Subject: Re: [PATCH V2 01/23] x86/ioreq: Prepare IOREQ feature for making it common To: Oleksandr Cc: Oleksandr Tyshchenko , Paul Durrant , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Julien Grall , Stefano Stabellini , Wei Liu , Julien Grall , xen-devel@lists.xenproject.org References: <1602780274-29141-1-git-send-email-olekstysh@gmail.com> <1602780274-29141-2-git-send-email-olekstysh@gmail.com> <61ea02e0-bdd4-5a0a-dd6f-b22e806e6d1e@suse.com> From: Jan Beulich Message-ID: Date: Fri, 13 Nov 2020 12:20:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 13.11.2020 12:09, Oleksandr wrote: > On 12.11.20 12:58, Jan Beulich wrote: >> On 15.10.2020 18:44, Oleksandr Tyshchenko wrote: >>> @@ -855,7 +841,7 @@ int hvm_destroy_ioreq_server(struct domain *d, ioservid_t id) >>> >>> domain_pause(d); >>> >>> - p2m_set_ioreq_server(d, 0, s); >>> + arch_hvm_destroy_ioreq_server(s); >> Iirc there are plans to rename hvm_destroy_ioreq_server() in the >> course of the generalization. If so, this arch hook would imo >> better be named following the new scheme right away. > Could you please clarify, are you speaking about the plans discussed there > > "[PATCH V2 12/23] xen/ioreq: Remove "hvm" prefixes from involved > function names"? > > Copy text for the convenience: > AT least some of the functions touched here would be nice to be > moved to a more consistent new naming scheme right away, to > avoid having to touch all the same places again. I guess ioreq > server functions would be nice to all start with ioreq_server_ > and ioreq functions to all start with ioreq_. E.g. ioreq_send() > and ioreq_server_select(). > > or some other plans I am not aware of? > > > What I really want to avoid with IOREQ enabling work is the round-trips > related to naming things, this patch series > became quite big (and consumes som time to rebase and test it) and I > expect it to become bigger. > > So the arch_hvm_destroy_ioreq_server() should be > arch_ioreq_server_destroy()? I think so, yes. If you want to avoid doing full patches, how about you simply list the functions / variables you plan to rename alongside the intended new names? Would likely be easier for all involved parties. >>> @@ -1215,7 +1153,7 @@ void hvm_destroy_all_ioreq_servers(struct domain *d) >>> struct hvm_ioreq_server *s; >>> unsigned int id; >>> >>> - if ( !relocate_portio_handler(d, 0xcf8, 0xcf8, 4) ) >>> + if ( !arch_hvm_ioreq_destroy(d) ) >> There's no ioreq being destroyed here, so I think this wants >> renaming (and again ideally right away following the planned >> new scheme). > Agree that no ioreq being destroyed here. Probably > ioreq_server_check_for_destroy()? > I couldn't think of a better name. "check" implies no change (and d ought to then be const struct domain *). With the containing function likely becoming ioreq_server_destroy_all(), arch_ioreq_server_destroy_all() would come to mind, or arch_ioreq_server_prepare_destroy_all(). >>> +static inline int hvm_map_mem_type_to_ioreq_server(struct domain *d, >>> + ioservid_t id, >>> + uint32_t type, >>> + uint32_t flags) >>> +{ >>> + struct hvm_ioreq_server *s; >>> + int rc; >>> + >>> + if ( type != HVMMEM_ioreq_server ) >>> + return -EINVAL; >>> + >>> + if ( flags & ~XEN_DMOP_IOREQ_MEM_ACCESS_WRITE ) >>> + return -EINVAL; >>> + >>> + spin_lock_recursive(&d->arch.hvm.ioreq_server.lock); >>> + >>> + s = get_ioreq_server(d, id); >>> + >>> + rc = -ENOENT; >>> + if ( !s ) >>> + goto out; >>> + >>> + rc = -EPERM; >>> + if ( s->emulator != current->domain ) >>> + goto out; >>> + >>> + rc = p2m_set_ioreq_server(d, flags, s); >>> + >>> + out: >>> + spin_unlock_recursive(&d->arch.hvm.ioreq_server.lock); >>> + >>> + if ( rc == 0 && flags == 0 ) >>> + { >>> + struct p2m_domain *p2m = p2m_get_hostp2m(d); >> I realize I may be asking too much, but would it be possible if, >> while moving code, you made simple and likely uncontroversial >> adjustments like adding const here? (Such adjustments would be >> less desirable to make if they increased the size of the patch, >> e.g. if you were touching only nearby code.) > This function as well as one located below won't be moved to this header > for the next version of patch. > > ok, will add const. Well, if you don't move the code, then better keep the diff small and leave things as they are. Jan