Re: [Xen-devel] [PATCH v6 00/10] TEE mediator (and OP-TEE) support in XEN

From: Julien Grall <julien.grall@arm.com>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Tim Deegan <tim@xen.org>,
	"tee-dev@lists.linaro.org" <tee-dev@lists.linaro.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH v6 00/10] TEE mediator (and OP-TEE) support in XEN
Date: Wed, 19 Jun 2019 12:08:49 +0100	[thread overview]
Message-ID: <e6340e20-f2f3-7604-e2be-2b2dac2d30a4@arm.com> (raw)
In-Reply-To: <20190611184541.7281-1-volodymyr_babchuk@epam.com>

Hello Volodymyr,

On 11/06/2019 19:46, Volodymyr Babchuk wrote:
> Volodymyr Babchuk (10):
>    xen/arm: add generic TEE mediator framework
>    xen/arm: optee: add OP-TEE header files
>    xen/arm: optee: add OP-TEE mediator skeleton
>    xen/arm: optee: add fast calls handling
>    xen/arm: optee: add std call handling
>    xen/arm: optee: add support for RPC SHM buffers
>    xen/arm: optee: add support for arbitrary shared memory
>    xen/arm: optee: add support for RPC commands

I have committed the first 8 patches.

>    tools/arm: tee: add "tee" option for xl.cfg
>    tools/arm: optee: create optee firmware node in DT if tee=optee

Please resend the last two patches with the comments addressed and follow-up on 
the others couple of improvements (docs and code) I suggested.

Cheers,

> 
>   MAINTAINERS                             |    6 +
>   docs/man/xl.cfg.5.pod.in                |   21 +
>   tools/libxl/libxl.h                     |    5 +
>   tools/libxl/libxl_arm.c                 |   42 +
>   tools/libxl/libxl_types.idl             |    6 +
>   tools/xl/xl_parse.c                     |    9 +
>   xen/arch/arm/Kconfig                    |    9 +
>   xen/arch/arm/Makefile                   |    1 +
>   xen/arch/arm/domain.c                   |   19 +
>   xen/arch/arm/setup.c                    |    2 +
>   xen/arch/arm/tee/Kconfig                |    4 +
>   xen/arch/arm/tee/Makefile               |    2 +
>   xen/arch/arm/tee/optee.c                | 1540 +++++++++++++++++++++++
>   xen/arch/arm/tee/tee.c                  |   98 ++
>   xen/arch/arm/vsmc.c                     |    5 +
>   xen/arch/arm/xen.lds.S                  |    7 +
>   xen/include/asm-arm/domain.h            |    4 +
>   xen/include/asm-arm/tee/optee_msg.h     |  310 +++++
>   xen/include/asm-arm/tee/optee_rpc_cmd.h |  318 +++++
>   xen/include/asm-arm/tee/optee_smc.h     |  564 +++++++++
>   xen/include/asm-arm/tee/tee.h           |  112 ++
>   xen/include/public/arch-arm.h           |    6 +
>   22 files changed, 3090 insertions(+)
>   create mode 100644 xen/arch/arm/tee/Kconfig
>   create mode 100644 xen/arch/arm/tee/Makefile
>   create mode 100644 xen/arch/arm/tee/optee.c
>   create mode 100644 xen/arch/arm/tee/tee.c
>   create mode 100644 xen/include/asm-arm/tee/optee_msg.h
>   create mode 100644 xen/include/asm-arm/tee/optee_rpc_cmd.h
>   create mode 100644 xen/include/asm-arm/tee/optee_smc.h
>   create mode 100644 xen/include/asm-arm/tee/tee.h
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel