From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@epam.com>
To: "Jürgen Groß" <jgross@suse.com>,
"Oleksandr Andrushchenko" <andr2000@gmail.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"ian.jackson@eu.citrix.com" <ian.jackson@eu.citrix.com>,
"wl@xen.org" <wl@xen.org>
Subject: Re: [PATCH v2] xen/displif: Protocol version 2
Date: Thu, 2 Jul 2020 07:59:37 +0000 [thread overview]
Message-ID: <f50ec904-8cb2-2bd6-c3ba-35e8c44bd607@epam.com> (raw)
In-Reply-To: <e442e4d9-fe79-7f65-c196-2a0a35923492@suse.com>
On 7/2/20 10:20 AM, Jürgen Groß wrote:
> On 01.07.20 14:07, Oleksandr Andrushchenko wrote:
>> On 7/1/20 1:46 PM, Jürgen Groß wrote:
>>> On 01.07.20 09:19, Oleksandr Andrushchenko wrote:
>>>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>>
>>>> 1. Add protocol version as an integer
>>>>
>>>> Version string, which is in fact an integer, is hard to handle in the
>>>> code that supports different protocol versions. To simplify that
>>>> also add the version as an integer.
>>>>
>>>> 2. Pass buffer offset with XENDISPL_OP_DBUF_CREATE
>>>>
>>>> There are cases when display data buffer is created with non-zero
>>>> offset to the data start. Handle such cases and provide that offset
>>>> while creating a display buffer.
>>>>
>>>> 3. Add XENDISPL_OP_GET_EDID command
>>>>
>>>> Add an optional request for reading Extended Display Identification
>>>> Data (EDID) structure which allows better configuration of the
>>>> display connectors over the configuration set in XenStore.
>>>> With this change connectors may have multiple resolutions defined
>>>> with respect to detailed timing definitions and additional properties
>>>> normally provided by displays.
>>>>
>>>> If this request is not supported by the backend then visible area
>>>> is defined by the relevant XenStore's "resolution" property.
>>>>
>>>> If backend provides extended display identification data (EDID) with
>>>> XENDISPL_OP_GET_EDID request then EDID values must take precedence
>>>> over the resolutions defined in XenStore.
>>>>
>>>> 4. Bump protocol version to 2.
>>>>
>>>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
>>>
>>> Reviewed-by: Juergen Gross <jgross@suse.com>
>>
>> Thank you, do you want me to prepare the same for the kernel so
>>
>> you have it at hand when the time comes?
>
> It should be added to the kernel only when really needed (i.e. a user of
> the new functionality is showing up).
We have a patch for that which adds EDID to the existing PV DRM frontend,
so while upstreaming those changes I will also include changes to the protocol
in the kernel series: for that we need the header in Xen tree first, right?
>
>
> Juergen
Thank you,
Oleksandr
next prev parent reply other threads:[~2020-07-02 7:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 7:19 [PATCH v2] xen/displif: Protocol version 2 Oleksandr Andrushchenko
2020-07-01 10:46 ` Jürgen Groß
2020-07-01 12:07 ` Oleksandr Andrushchenko
2020-07-02 7:20 ` Jürgen Groß
2020-07-02 7:59 ` Oleksandr Andrushchenko [this message]
2020-07-02 8:42 ` Jürgen Groß
2020-07-08 5:59 ` Oleksandr Andrushchenko
2020-07-27 6:50 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f50ec904-8cb2-2bd6-c3ba-35e8c44bd607@epam.com \
--to=oleksandr_andrushchenko@epam.com \
--cc=andr2000@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).