Re: [PATCH 1/7] minor (formatting) fixes

[Corneliu ZUZU <czuzu@bitdefender.com>]

On 6/16/2016 5:24 PM, Jan Beulich wrote:
>>>> On 16.06.16 at 16:06, <czuzu@bitdefender.com> wrote:
>> --- a/xen/arch/x86/hvm/event.c
>> +++ b/xen/arch/x86/hvm/event.c
>> @@ -23,6 +23,7 @@
>>   
>>   #include <xen/vm_event.h>
>>   #include <asm/hvm/event.h>
>> +#include <asm/paging.h>
>>   #include <asm/monitor.h>
>>   #include <asm/vm_event.h>
>>   #include <public/vm_event.h>
>> diff --git a/xen/common/monitor.c b/xen/common/monitor.c
>> index d950a7c..b30857a 100644
>> --- a/xen/common/monitor.c
>> +++ b/xen/common/monitor.c
>> @@ -22,7 +22,6 @@
>>   #include <xen/monitor.h>
>>   #include <xen/sched.h>
>>   #include <xsm/xsm.h>
>> -#include <public/domctl.h>
>>   #include <asm/monitor.h>
>>   #include <asm/vm_event.h>
> These two adjustments clearly don't fit title / description. I certainly
> don't mind unnecessary inclusions to be dropped, but the addition of
> one clearly needs explanation (after all thing build fine without it).

Sorry, that was done out of reflex, should have stated the reasoning.
Generally, if:
- event.c includes event.h
- event.c needs paging.h
- event.h -doesn't need- paging.h
then I prefer to include paging.h in event.c, not in event.h (include 
strictly -where- needed).
Also since xen/paging.h included asm/paging.h and event.c only needs the 
asm/paging.h part, I also changed xen/paging.h inclusion -> asm/paging.h 
inclusion (include strictly -what's- needed).
But I can revert that if you want me to (not that important and these 
little things are better done with automatic tools anyway), or should I 
leave the change and update the commit message?

>> --- a/xen/include/asm-x86/vm_event.h
>> +++ b/xen/include/asm-x86/vm_event.h
>> @@ -44,6 +44,9 @@ void vm_event_set_registers(struct vcpu *v, vm_event_response_t *rsp);
>>   
>>   void vm_event_fill_regs(vm_event_request_t *req);
>>   
>> +/*
>> + * Monitor vm-events.
>> + */
> This is a single line comment (also elsewhere).

Ack.

>
>> --- a/xen/include/xen/vm_event.h
>> +++ b/xen/include/xen/vm_event.h
>> @@ -85,7 +85,6 @@ void vm_event_monitor_guest_request(void);
>>   
>>   #endif /* __VM_EVENT_H__ */
>>   
>> -
>>   /*
>>    * Local variables:
>>    * mode: C
> Why don't you remove the other stray blank line at once?
>
> Jan

What stray line? Shouldn't there be -one- blank line between the #endif 
and the local vars block?
Looking @ other files that rule seems to hold...

Corneliu.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel