From: Julien Grall <julien@xen.org>
To: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Ian Jackson <iwj@xenproject.org>,
Stefano Stabellini <sstabellini@kernel.org>, Wei Liu <wl@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3 12/15] unxz: replace INIT{,DATA} and STATIC
Date: Thu, 15 Apr 2021 15:55:47 +0100 [thread overview]
Message-ID: <ffbe985e-c8a7-331c-cb6d-6f4621b5c71c@xen.org> (raw)
In-Reply-To: <a76656e4-1b19-df2f-aba0-e7b26b3ab968@suse.com>
On 15/04/2021 15:28, Jan Beulich wrote:
> On 15.04.2021 16:24, Julien Grall wrote:
>>
>>
>> On 15/04/2021 15:22, Jan Beulich wrote:
>>> On 15.04.2021 16:18, Julien Grall wrote:
>>>>
>>>>
>>>> On 15/04/2021 15:16, Jan Beulich wrote:
>>>>> On 15.04.2021 13:58, Julien Grall wrote:
>>>>>> On 26/01/2021 09:52, Jan Beulich wrote:
>>>>>>> --- a/xen/common/decompress.h
>>>>>>> +++ b/xen/common/decompress.h
>>>>>>> @@ -9,7 +9,6 @@
>>>>>>>
>>>>>>> #define STATIC static
>>>>>>> #define INIT __init
>>>>>>> -#define INITDATA __initdata
>>>>>>>
>>>>>>> #define malloc xmalloc_bytes
>>>>>>> #define free xfree
>>>>>>> @@ -21,7 +20,6 @@
>>>>>>>
>>>>>>> #define STATIC static
>>>>>>> #define INIT
>>>>>>> -#define INITDATA
>>>>>>
>>>>>> Shouldn't the two changes be part of patch #14?
>>>>>
>>>>> One could do it that way, sure, but the last uses are gone here,
>>>>> and hence I wanted to get rid of this one item right away.
>>>>
>>>> AFAICT, the same is true for STATIC and INIT. So it doesn't sense to not
>>>> be consistent in the way you treat them.
>>>
>>> No, further uses of STATIC and INIT get dropped by later patches.
>>
>> I think you misundertood my comment. What I meant is you drop INIT in
>> patch #14 when the last caller was dropped in a previous patch.
>
> Now this and some other of your comments are getting really nitpicky.
You misundertood my question, so I was clarifying what I meant.
> The end result is the same. I can certainly move removals around
> further, but I think I ought to have some leeway on how exactly I
> achieve an identical end result. Things would be different, I agree,
> if the end result was not suitably consistent.
As I mentionned in patch #14, this is not very different from requesting
to reshuffle the code. I find a bit surprising you are complaining about
this...
I guess I could have add NIT in front to make clearer this was only a
suggestion.
From your answer, I am assuming this is a no which is fair:
Acked-by: Julien Grall <jgrall@amazon.com>
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2021-04-15 14:56 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 9:46 [PATCH v3 00/15] zstd decompression for DomU-s + fallout / consolidation Jan Beulich
2021-01-26 9:48 ` [PATCH v3 01/15] libxenguest: add get_unaligned_le32() Jan Beulich
2021-01-26 11:51 ` Ian Jackson
2021-01-26 9:49 ` [PATCH v3 02/15] libxenguest: support zstd compressed kernels Jan Beulich
2021-01-26 11:53 ` Ian Jackson
2021-01-26 9:49 ` [PATCH v3 03/15] xen/decompress: make helper symbols static Jan Beulich
2021-01-26 9:49 ` [PATCH v3 04/15] libxenguest: "standardize" LZO kernel decompression code Jan Beulich
2021-01-26 9:50 ` [PATCH v3 05/15] libxenguest: drop redundant decompression declarations Jan Beulich
2021-01-26 9:50 ` [PATCH v3 06/15] libxenguest: simplify kernel decompression Jan Beulich
2021-01-26 9:50 ` [PATCH v3 01/15] gunzip: drop INIT{,DATA} and STATIC Jan Beulich
2021-01-26 9:54 ` Jan Beulich
2021-01-26 11:56 ` Ian Jackson
2021-01-26 12:49 ` Jan Beulich
2021-01-26 9:51 ` [PATCH v3 08/15] bunzip: replace INIT Jan Beulich
2021-04-15 11:50 ` Julien Grall
2021-01-26 9:51 ` [PATCH v3 09/15] unlzo: " Jan Beulich
2021-04-15 11:51 ` Julien Grall
2021-01-26 9:51 ` [PATCH v3 10/15] unlzma: " Jan Beulich
2021-04-15 11:52 ` Julien Grall
2021-01-26 9:52 ` [PATCH v3 11/15] unlz4: " Jan Beulich
2021-04-15 11:56 ` Julien Grall
2021-01-26 9:52 ` [PATCH v3 12/15] unxz: replace INIT{,DATA} and STATIC Jan Beulich
2021-04-15 11:58 ` Julien Grall
2021-04-15 14:16 ` Jan Beulich
2021-04-15 14:18 ` Julien Grall
2021-04-15 14:22 ` Jan Beulich
2021-04-15 14:24 ` Julien Grall
2021-04-15 14:28 ` Jan Beulich
2021-04-15 14:55 ` Julien Grall [this message]
2021-01-26 9:52 ` [PATCH v3 13/15] unzstd: " Jan Beulich
2021-04-15 11:59 ` Julien Grall
2021-04-15 14:21 ` Jan Beulich
2021-04-15 14:22 ` Julien Grall
2021-04-15 14:25 ` Jan Beulich
2021-04-15 14:30 ` Julien Grall
2021-04-15 14:34 ` Jan Beulich
2021-04-15 14:47 ` Julien Grall
2021-01-26 9:53 ` [PATCH v3 14/15] xen/decompress: drop STATIC and INIT Jan Beulich
2021-04-15 14:21 ` Julien Grall
2021-04-15 14:32 ` Jan Beulich
2021-04-15 14:45 ` Julien Grall
2021-01-26 9:53 ` [PATCH v3 15/15] unzstd: make helper symbols static Jan Beulich
2021-04-15 12:09 ` Julien Grall
2021-04-15 14:37 ` Jan Beulich
2021-01-26 12:05 ` [PATCH v3 00/15] zstd decompression for DomU-s + fallout / consolidation Ian Jackson
2021-01-26 13:04 ` Jan Beulich
2021-01-26 13:25 ` Ian Jackson
2021-01-26 13:50 ` Jan Beulich
2021-04-15 9:20 ` Ping: " Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffbe985e-c8a7-331c-cb6d-6f4621b5c71c@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).