From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F13C2C433ED for ; Thu, 8 Apr 2021 05:59:22 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9AB21601FF for ; Thu, 8 Apr 2021 05:59:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9AB21601FF Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.107032.204576 (Exim 4.92) (envelope-from ) id 1lUNhB-0007q3-I8; Thu, 08 Apr 2021 05:59:13 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 107032.204576; Thu, 08 Apr 2021 05:59:13 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUNhB-0007pw-En; Thu, 08 Apr 2021 05:59:13 +0000 Received: by outflank-mailman (input) for mailman id 107032; Thu, 08 Apr 2021 05:59:12 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1lUNhA-0007pr-LN for xen-devel@lists.xenproject.org; Thu, 08 Apr 2021 05:59:12 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 95d2a5ac-4fa1-4e45-a4f7-78348abf45cf; Thu, 08 Apr 2021 05:59:11 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C9A49AFF0; Thu, 8 Apr 2021 05:59:10 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 95d2a5ac-4fa1-4e45-a4f7-78348abf45cf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1617861550; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vC86PYGgQMb1wZaGNQa7XS4J1uayXt8bj0eXJ/Vtguk=; b=SlC5Zl0hivgWapOQTNsaLWwT5YKQj4ReWhi9CR2e+Ny1A6mDv2eoxjRiVxp+kYBaH4X8g0 kNOtEhZjHtC8AW6jlBt2RFOWDYPbf51HxAHBgemmJ/hL4jpX8aXLmqar4/DG2okGQ0BPrp 0JxtufVVglYxNdg0XH8esWfVUO/aLP0= Subject: Re: [PATCH 3/3] docs/doxygen: doxygen documentation for grant_table.h To: Stefano Stabellini Cc: Luca Fancellu , Bertrand Marquis , wei.chen@arm.com, Andrew Cooper , George Dunlap , Ian Jackson , Julien Grall , Wei Liu , xen-devel@lists.xenproject.org References: <20210406103603.8530-1-luca.fancellu@arm.com> <20210406103603.8530-4-luca.fancellu@arm.com> <073e28bc-ad94-429d-6384-744864d12b57@suse.com> <5cad4ffb-44ec-4cde-f5bb-f59dc3ca59ca@suse.com> From: Jan Beulich Message-ID: Date: Thu, 8 Apr 2021 07:59:10 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07.04.2021 23:26, Stefano Stabellini wrote: > On Wed, 7 Apr 2021, Jan Beulich wrote: >> On 07.04.2021 10:42, Luca Fancellu wrote: >>> Just to be sure that we are in the same page, are you suggesting to modify the name >>> In this way? >>> >>> struct gnttab_cache_flush { >>> - union { >>> + union xen_gnttab_cache_flush_a { >>> uint64_t dev_bus_addr; >>> grant_ref_t ref; >>> } a; >>> >>> Following this kind of pattern: xen__ ? >> >> While in general I would be fine with this scheme, for field names like >> "a" or "u" it doesn't fit well imo. > > "a" is a bad name anyway, even for the member. We can take the > opportunity to find a better name. Almost anything would be better than > "a". Maybe "refaddr"? We need to be careful with changing _anything_ in the public interface. Consumers importing our headers directly (as was e.g. done for the old linux-2.6.18-xen.hg tree) could break with a field name change as much as with any other changes to what had been made available to them. Jan