Re: [PATCH] Makefile: generate 'git' as 'cc [...] -o git+ && mv git+ git'

From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] Makefile: generate 'git' as 'cc [...] -o git+ && mv git+ git'
Date: Sun, 07 Mar 2021 12:41:08 -0800	[thread overview]
Message-ID: <xmqq35x68zob.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20210307132001.7485-1-avarab@gmail.com> (=?utf-8?B?IsOGdmFy?= =?utf-8?B?IEFybmZqw7Zyw7A=?= Bjarmason"'s message of "Sun, 7 Mar 2021 14:20:01 +0100")

Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Change the compilation of the main 'git' binary to not have the CC
> clobber 'git' in-place. This means that e.g. running the test suite
> in-place and recompiling won't fail whatever tests happen to be
> running for the duration of the binary being regenerated.

I am not sure why I would want to support the workflow this is
trying to help.

I do not want to see a patch on this list claiming that "While the
whole test suite is running, I tweaked the source three times and
recompiled, so some tests may have used my second iteration while
others may have used my third and the final version of the code---in
any case, all tests passed".  And when a patch that was developed
that way came in, I do not want to hear "Yes, the test suite used
mixed binaries, but I KNOW the difference between my second and
third iteration should not matter the parts of the earlier tests
that used the older iteration".