From: <fys@fysnet.net>
To: "'Gerd Hoffmann'" <kraxel@redhat.com>, <qemu-devel@nongnu.org>
Subject: RE: [PATCH v2] uas: fix super speed bMaxPacketSize0
Date: Fri, 17 Jan 2020 13:05:52 -0700 [thread overview]
Message-ID: <000001d5cd71$86eec090$94cc41b0$@fysnet.net> (raw)
In-Reply-To: <20200117073716.31335-1-kraxel@redhat.com>
I am okay with this patch. Thank you.
Ben
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Friday, January 17, 2020 12:37 AM
> To: qemu-devel@nongnu.org
> Cc: fys@fysnet.net; Gerd Hoffmann <kraxel@redhat.com>
> Subject: [PATCH v2] uas: fix super speed bMaxPacketSize0
>
> For usb2 bMaxPacketSize0 is "n", for usb3 it is "1 << n", so it must be 9 not 64
> ...
>
> rom "Universal Serial Bus 3.1 Specification":
>
> If the device is operating at Gen X speed, the bMaxPacketSize0
> field shall be set to 09H indicating a 512-byte maximum packet.
> An Enhanced SuperSpeed device shall not support any other maximum
> packet sizes for the default control pipe (endpoint 0) control
> endpoint.
>
> We now announce a 512-byte maximum packet.
>
> Fixes: 89a453d4a5c ("uas-uas: usb3 streams")
> Reported-by: Benjamin David Lunt <fys@fysnet.net>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/usb/dev-uas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/dev-uas.c b/hw/usb/dev-uas.c index
> 6d6d1073b907..1bc4dd4fafb8 100644
> --- a/hw/usb/dev-uas.c
> +++ b/hw/usb/dev-uas.c
> @@ -303,7 +303,7 @@ static const USBDescDevice desc_device_high = {
>
> static const USBDescDevice desc_device_super = {
> .bcdUSB = 0x0300,
> - .bMaxPacketSize0 = 64,
> + .bMaxPacketSize0 = 9,
> .bNumConfigurations = 1,
> .confs = (USBDescConfig[]) {
> {
> --
> 2.18.1
prev parent reply other threads:[~2020-01-17 20:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 7:37 [PATCH v2] uas: fix super speed bMaxPacketSize0 Gerd Hoffmann
2020-01-17 7:44 ` Philippe Mathieu-Daudé
2020-01-17 20:05 ` fys [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d5cd71$86eec090$94cc41b0$@fysnet.net' \
--to=fys@fysnet.net \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.