From: Jingoo Han <jg1.han@samsung.com>
To: "'Lothar Waßmann'" <LW@KARO-electronics.de>,
"'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org,
"'Simon Budig'" <simon.budig@kernelconcepts.de>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Pawel Moll'" <pawel.moll@arm.com>,
"'Mark Rutland'" <mark.rutland@arm.com>,
"'Ian Campbell'" <ijc+devicetree@hellion.org.uk>,
"'Kumar Gala'" <galak@codeaurora.org>,
"'Rob Landley'" <rob@landley.net>,
"'Thierry Reding'" <thierry.reding@gmail.com>,
"'Grant Likely'" <grant.likely@linaro.org>,
"'Jonathan Cameron'" <jic23@kernel.org>,
"'Shawn Guo'" <shawn.guo@linaro.org>,
"'Silvio F'" <silvio.fricke@gmail.com>,
"'Guennadi Liakhovetski'" <g.liakhovetski@gmx.de>,
"'Fugang Duan'" <B38611@freescale.com>,
"'Sachin Kamat'" <sachin.kamat@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCHv2 3/3] Input: edt-ft5x06: Add DT support
Date: Fri, 17 Jan 2014 10:36:42 +0900 [thread overview]
Message-ID: <000101cf1324$932c0600$b9841200$%han@samsung.com> (raw)
In-Reply-To: <20140117002649.GA837@core.coreip.homeip.net>
On Friday, January 17, 2014 9:27 AM, Dmitry Torokhov wrote:
> On Thu, Jan 16, 2014 at 09:02:18AM +0100, Lothar Waßmann wrote:
> >
> > Signed-off-by: Lothar Waßmann <LW@KARO-electronics.de>
> > ---
> > .../bindings/input/touchscreen/edt-ft5x06.txt | 29 +++++
> > drivers/input/touchscreen/edt-ft5x06.c | 121 +++++++++++++++++---
> > 2 files changed, 132 insertions(+), 18 deletions(-)
> > create mode 100644 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.txt
> >
[.....]
> > + if (gpio_is_valid(tsdata->reset_pin)) {
> > /* this pulls reset down, enabling the low active reset */
> > - error = devm_gpio_request_one(&client->dev, reset_pin,
> > + error = devm_gpio_request_one(&client->dev, tsdata->reset_pin,
> > GPIOF_OUT_INIT_LOW,
> > "edt-ft5x06 reset");
> > if (error) {
> > dev_err(&client->dev,
> > "Failed to request GPIO %d as reset pin, error %d\n",
> > - reset_pin, error);
> > + tsdata->reset_pin, error);
> > return error;
> > }
> >
> > - mdelay(50);
> > - gpio_set_value(reset_pin, 1);
> > - mdelay(100);
> > + mdelay(5);
> > + gpio_set_value(tsdata->reset_pin, 1);
> > + mdelay(300);
>
> Hmm, this change seems unrelated to DT support.
Right, modifying delay timing is not related to DT support.
In this case, this patch should be split, and the patch should
address the reason why delay timing is modified.
Also, 300 msec is a huge delay. Thus, comment will be helpful.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2014-01-17 1:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 8:02 [PATCHv2 0/3] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-16 8:02 ` [PATCHv2 1/3] Input: edt_ft5x06: use devm_* functions where appropriate Lothar Waßmann
2014-01-17 0:28 ` Dmitry Torokhov
2014-01-17 0:28 ` Dmitry Torokhov
2014-01-16 8:02 ` [PATCHv2 2/3] DT: Add vendor prefix for Emerging Display Technologies Lothar Waßmann
2014-01-16 8:02 ` [PATCHv2 3/3] Input: edt-ft5x06: Add DT support Lothar Waßmann
2014-01-17 0:26 ` Dmitry Torokhov
2014-01-17 0:26 ` Dmitry Torokhov
2014-01-17 1:36 ` Jingoo Han [this message]
2014-01-17 1:46 ` Simon Budig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101cf1324$932c0600$b9841200$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=B38611@freescale.com \
--cc=LW@KARO-electronics.de \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=g.liakhovetski@gmx.de \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=silvio.fricke@gmail.com \
--cc=simon.budig@kernelconcepts.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.