From: "Doug Smythies" <dsmythies@telus.net>
To: "'Rafael J. Wysocki'" <rjw@rjwysocki.net>
Cc: "'Peter Zijlstra'" <peterz@infradead.org>,
"'Daniel Lezcano'" <daniel.lezcano@linaro.org>,
"'Linux PM'" <linux-pm@vger.kernel.org>
Subject: RE: [RFC][PATCH] cpuidle: Consolidate disabled state checks
Date: Fri, 20 Sep 2019 09:14:53 -0700 [thread overview]
Message-ID: <000301d56fce$8b291850$a17b48f0$@net> (raw)
In-Reply-To: <2136682.Ujdk25Y4fk@kreacher>
Hi Rafael,
To be able to try this patch (and the nanosecond as unit of time one),
I simply waited until it would apply properly in the main git tree, which it now does.
However it does not compile:
On 2019.09.04 03:41 Rafael J. Wysocki wrote:
...
> Index: linux-pm/drivers/cpuidle/governors/menu.c
> ===================================================================
> --- linux-pm.orig/drivers/cpuidle/governors/menu.c
> +++ linux-pm/drivers/cpuidle/governors/menu.c
> @@ -298,7 +298,7 @@ static int menu_select(struct cpuidle_dr
> if (unlikely(drv->state_count <= 1 || latency_req == 0) ||
> ((data->next_timer_us < drv->states[1].target_residency ||
> latency_req < drv->states[1].exit_latency) &&
> - !drv->states[0].disabled && !dev->states_usage[0].disable)) {
> + !dev->states_usage[0].disable)) {
> /*
> * In this case state[0] will be used no matter what, so return
> * it right away and keep the tick running if state[0] is a
> @@ -349,9 +349,8 @@ static int menu_select(struct cpuidle_dr
> idx = -1;
> for (i = 0; i < drv->state_count; i++) {
> struct cpuidle_state *s = &drv->states[i];
> - struct cpuidle_state_usage *su = &dev->states_usage[i];
>
> - if (s->disabled || su->disable)
> + if (dev->states_usage[i]->disable)
^^^^^^^^^^
Should be (I think):
+ if (dev->states_usage[i].disable)
... Doug
prev parent reply other threads:[~2019-09-20 16:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 10:41 [RFC][PATCH] cpuidle: Consolidate disabled state checks Rafael J. Wysocki
2019-09-04 13:03 ` Peter Zijlstra
2019-09-04 21:54 ` Daniel Lezcano
2019-09-20 16:14 ` Doug Smythies [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301d56fce$8b291850$a17b48f0$@net' \
--to=dsmythies@telus.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.