RE: [PATCH v2 02/11] xen/gnttab: Rework resource acquisition

From: Paul Durrant <xadimgnik@gmail.com>
To: "'Andrew Cooper'" <amc96@cam.ac.uk>,
	"'Xen-devel'" <xen-devel@lists.xenproject.org>
Cc: "'George Dunlap'" <George.Dunlap@eu.citrix.com>,
	"'Ian Jackson'" <iwj@xenproject.org>,
	"'Jan Beulich'" <JBeulich@suse.com>,
	"'Stefano Stabellini'" <sstabellini@kernel.org>,
	"'Wei Liu'" <wl@xen.org>, "'Julien Grall'" <julien@xen.org>,
	"'Michał Leszczyński'" <michal.leszczynski@cert.pl>,
	"'Hubert Jasudowicz'" <hubert.jasudowicz@cert.pl>,
	"'Tamas K Lengyel'" <tamas@tklengyel.com>
Subject: RE: [PATCH v2 02/11] xen/gnttab: Rework resource acquisition
Date: Tue, 12 Jan 2021 08:29:08 -0000	[thread overview]
Message-ID: <001c01d6e8bc$ffa46d70$feed4850$@xen.org> (raw)
In-Reply-To: <835893e1-fcd0-efa1-86ce-02af70dd1101@cam.ac.uk>

> -----Original Message-----
> From: Andrew Cooper <amc96@cam.ac.uk>
> Sent: 11 January 2021 21:23
> To: paul@xen.org; 'Xen-devel' <xen-devel@lists.xenproject.org>
> Cc: 'George Dunlap' <George.Dunlap@eu.citrix.com>; 'Ian Jackson' <iwj@xenproject.org>; 'Jan Beulich'
> <JBeulich@suse.com>; 'Stefano Stabellini' <sstabellini@kernel.org>; 'Wei Liu' <wl@xen.org>; 'Julien
> Grall' <julien@xen.org>; 'Michał Leszczyński' <michal.leszczynski@cert.pl>; 'Hubert Jasudowicz'
> <hubert.jasudowicz@cert.pl>; 'Tamas K Lengyel' <tamas@tklengyel.com>; Andrew Cooper <amc96@cam.ac.uk>
> Subject: Re: [PATCH v2 02/11] xen/gnttab: Rework resource acquisition
> 
> On 24/09/2020 10:51, Paul Durrant wrote:
> >> diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c
> >> index a5d3ed8bda..912f07be47 100644
> >> --- a/xen/common/grant_table.c
> >> +++ b/xen/common/grant_table.c
> >> @@ -4013,6 +4013,81 @@ static int gnttab_get_shared_frame_mfn(struct domain *d,
> >>      return 0;
> >>  }
> >>
> >> +int gnttab_acquire_resource(
> >> +    struct domain *d, unsigned int id, unsigned long frame,
> >> +    unsigned int nr_frames, xen_pfn_t mfn_list[])
> >> +{
> >> +    struct grant_table *gt = d->grant_table;
> >> +    unsigned int i = nr_frames, tot_frames;
> >> +    mfn_t tmp;
> >> +    void **vaddrs = NULL;
> >> +    int rc;
> >> +
> >> +    /* Input sanity. */
> > Nit: inconsistency with full stops on single line comments.
> 
> The whole point of relaxing the style was because feedback over minutia
> such as this was deemed detrimental to the community.
> 
> If I ever see feedback like this, I will commit commit the patch there
> and then.  This is the only way upstream Xen is going to turn into a
> less toxic environment for contributors.

The tone of your response rather proves that Xen is already a toxic environment, I'm afraid.

  Paul