From: "Namjae Jeon" <namjae.jeon@samsung.com>
To: "'Wei Yongjun'" <weiyongjun1@huawei.com>,
"'Sergey Senozhatsky'" <sergey.senozhatsky@gmail.com>,
"'Steve French'" <sfrench@samba.org>,
"'Hyunchul Lee'" <hyc.lee@gmail.com>
Cc: <linux-cifs@vger.kernel.org>,
<linux-cifsd-devel@lists.sourceforge.net>,
<kernel-janitors@vger.kernel.org>,
"'Hulk Robot'" <hulkci@huawei.com>
Subject: RE: [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY
Date: Fri, 21 May 2021 09:56:38 +0900 [thread overview]
Message-ID: <002501d74ddc$27b5d1d0$77217570$@samsung.com> (raw)
In-Reply-To: <20210520134211.1667806-1-weiyongjun1@huawei.com>
> Fix build error when CONFIG_OID_REGISTRY is not set:
>
> mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `gssapi_this_mech':
> asn1.c:(.text+0xaa0): undefined reference to `sprint_oid'
> mips-linux-gnu-ld: fs/cifsd/asn1.o: in function `neg_token_init_mech_type':
> asn1.c:(.text+0xbec): undefined reference to `sprint_oid'
>
> Fixes: fad4161b5cd0 ("cifsd: decoding gss token using lib/asn1_decoder.c")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
I will apply it. Thanks for your patch!
Hyunchul, You also need to add this change to your cifs patch.
> ---
> fs/cifsd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/cifsd/Kconfig b/fs/cifsd/Kconfig index 5316b1035fbe..e6448b04f46e 100644
> --- a/fs/cifsd/Kconfig
> +++ b/fs/cifsd/Kconfig
> @@ -18,6 +18,7 @@ config SMB_SERVER
> select CRYPTO_CCM
> select CRYPTO_GCM
> select ASN1
> + select OID_REGISTRY
> default n
> help
> Choose Y here if you want to allow SMB3 compliant clients
next prev parent reply other threads:[~2021-05-21 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210520133301epcas1p325b7d973e4febb2e9832051462585213@epcas1p3.samsung.com>
2021-05-20 13:42 ` [PATCH -next] cifsd: fix build error without CONFIG_OID_REGISTRY Wei Yongjun
2021-05-21 0:56 ` Namjae Jeon [this message]
2021-05-21 1:28 ` Hyunchul Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002501d74ddc$27b5d1d0$77217570$@samsung.com' \
--to=namjae.jeon@samsung.com \
--cc=hulkci@huawei.com \
--cc=hyc.lee@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-cifsd-devel@lists.sourceforge.net \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfrench@samba.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.