RE: [PATCH v2 09/10] tools/power turbostat: Print cpuidle information

From: "Doug Smythies" <dsmythies@telus.net>
To: "'Len Brown'" <lenb@kernel.org>, <linux-pm@vger.kernel.org>
Cc: "'Len Brown'" <len.brown@intel.com>,
	"'Antti Laakso'" <antti.laakso@linux.intel.com>
Subject: RE: [PATCH v2 09/10] tools/power turbostat: Print cpuidle information
Date: Tue, 24 Mar 2020 17:50:52 -0700	[thread overview]
Message-ID: <003101d6023f$70975750$51c605f0$@net> (raw)
In-Reply-To: <abdcbdb265264f736df316622a695ad30019c05f.1584766216.git.len.brown@intel.com>

Hi Len,

On 2020.03.20 21:55 Len Brown wrote:

> From: Len Brown <len.brown@intel.com>
>
> Print cpuidle driver and governor.
> 
> Originally-by: Antti Laakso <antti.laakso@linux.intel.com>
> Signed-off-by: Len Brown <len.brown@intel.com>
> ---
> tools/power/x86/turbostat/turbostat.c | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
> index 77f89371ec5f..05dbe23570d4 100644
> --- a/tools/power/x86/turbostat/turbostat.c
> +++ b/tools/power/x86/turbostat/turbostat.c

... 

> 
> static void
> dump_sysfs_cstate_config(void)
> {
> @@ -3516,6 +3533,15 @@ dump_sysfs_cstate_config(void)
> 	if (!DO_BIC(BIC_sysfs))
> 		return;

I do not understand why this information needs to be
a function of the --show options and not solely a
function of the --quiet option.

My reasoning is that I almost always want all the information
possible in the start spew of stuff, and if I don't I'll
use --quiet option. However, I rarely show more than
about 6 columns at a time resulting in intermittent inclusion
of this information.

> 
> +	if (access("/sys/devices/system/cpu/cpuidle", R_OK)) {
> +		fprintf(outf, "cpuidle not loaded\n");
> +		return;
> +	}
> +
> +	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_driver");
> +	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor");
> +	dump_sysfs_file("/sys/devices/system/cpu/cpuidle/current_governor_ro");
> +
>  	for (state = 0; state < 10; ++state) {
>  
> 		sprintf(path, "/sys/devices/system/cpu/cpu%d/cpuidle/state%d/name",