From: Adrian Hunter <adrian.hunter@intel.com>
To: Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Can Guo <quic_cang@quicinc.com>,
Manivannan Sadhasivam <mani@kernel.org>,
Asutosh Das <quic_asutoshd@quicinc.com>,
Arthur Simchaev <Arthur.Simchaev@wdc.com>,
Jinyoung Choi <j-young.choi@samsung.com>,
Bean Huo <beanhuo@micron.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Avri Altman <avri.altman@wdc.com>
Subject: Re: [PATCH v4 4/5] scsi: ufs: Declare ufshcd_{hold,release}() once
Date: Tue, 30 May 2023 12:48:08 +0300 [thread overview]
Message-ID: <0130e6e7-bf86-eae0-ac25-3755798a5703@intel.com> (raw)
In-Reply-To: <20230529202640.11883-5-bvanassche@acm.org>
On 29/05/23 23:26, Bart Van Assche wrote:
> ufshcd_hold() and ufshcd_release are declared twice: once in
> drivers/ufs/core/ufshcd-priv.h and a second time in include/ufs/ufshcd.h.
> Remove the declarations from ufshcd-priv.h.
>
> Fixes: dd11376b9f1b ("scsi: ufs: Split the drivers/scsi/ufs directory")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/ufs/core/ufshcd-priv.h | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h
> index d53b93c21a0c..8f58c2169398 100644
> --- a/drivers/ufs/core/ufshcd-priv.h
> +++ b/drivers/ufs/core/ufshcd-priv.h
> @@ -84,9 +84,6 @@ unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba,
> int ufshcd_read_string_desc(struct ufs_hba *hba, u8 desc_index,
> u8 **buf, bool ascii);
>
> -int ufshcd_hold(struct ufs_hba *hba, bool async);
> -void ufshcd_release(struct ufs_hba *hba);
> -
> int ufshcd_send_uic_cmd(struct ufs_hba *hba, struct uic_command *uic_cmd);
>
> int ufshcd_exec_raw_upiu_cmd(struct ufs_hba *hba,
next prev parent reply other threads:[~2023-05-30 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 20:26 [PATCH v4 0/5] ufs: Do not requeue while ungating the clock Bart Van Assche
2023-05-29 20:26 ` [PATCH v4 1/5] scsi: core: Rework scsi_host_block() Bart Van Assche
2023-05-29 20:26 ` [PATCH v4 2/5] scsi: core: Support setting BLK_MQ_F_BLOCKING Bart Van Assche
2023-05-29 20:26 ` [PATCH v4 3/5] scsi: ufs: Conditionally enable the BLK_MQ_F_BLOCKING flag Bart Van Assche
2023-05-30 9:52 ` Bean Huo
2023-05-29 20:26 ` [PATCH v4 4/5] scsi: ufs: Declare ufshcd_{hold,release}() once Bart Van Assche
2023-05-30 9:48 ` Adrian Hunter [this message]
2023-05-29 20:26 ` [PATCH v4 5/5] scsi: ufs: Ungate the clock synchronously Bart Van Assche
2023-05-30 11:10 ` Bean Huo
2023-05-30 17:39 ` Bao D. Nguyen
[not found] ` <CGME20230529202702epcas2p2ab96250338c67cef61f4bbd479c2c73b@epcms2p7>
2023-05-31 7:59 ` [PATCH v4 4/5] scsi: ufs: Declare ufshcd_{hold,release}() once Keoseong Park
2023-05-31 15:45 ` [PATCH v4 0/5] ufs: Do not requeue while ungating the clock Martin K. Petersen
2023-06-08 1:42 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2023-05-29 20:21 [PATCH] scsi: stex: Fix gcc 13 warnings Bart Van Assche
2023-05-29 20:21 ` [PATCH v4 4/5] scsi: ufs: Declare ufshcd_{hold,release}() once Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0130e6e7-bf86-eae0-ac25-3755798a5703@intel.com \
--to=adrian.hunter@intel.com \
--cc=Arthur.Simchaev@wdc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=j-young.choi@samsung.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mani@kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.