Re: [PATCH 0/4] Add support for HiSilicon PCIe Tune and Trace device

From: Yicong Yang <yangyicong@hisilicon.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: <alexander.shishkin@linux.intel.com>, <helgaas@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<lorenzo.pieralisi@arm.com>, <jonathan.cameron@huawei.com>,
	<song.bao.hua@hisilicon.com>, <prime.zeng@huawei.com>,
	<linux-doc@vger.kernel.org>, <linuxarm@huawei.com>,
	"liuqi (BA)" <liuqi115@huawei.com>
Subject: Re: [PATCH 0/4] Add support for HiSilicon PCIe Tune and Trace device
Date: Wed, 7 Apr 2021 18:03:11 +0800	[thread overview]
Message-ID: <01b6e8f7-3282-514e-818d-0e768dcc5ba3@hisilicon.com> (raw)
In-Reply-To: <YGxm49c9cT69NV5Q@kroah.com>

On 2021/4/6 21:49, Greg KH wrote:
> On Tue, Apr 06, 2021 at 08:45:50PM +0800, Yicong Yang wrote:
>> HiSilicon PCIe tune and trace device(PTT) is a PCIe Root Complex
>> integrated Endpoint(RCiEP) device, providing the capability
>> to dynamically monitor and tune the PCIe traffic(tune),
>> and trace the TLP headers(trace). The driver exposes the user
>> interface through debugfs, so no need for extra user space tools.
>> The usage is described in the document.
> 
> Why use debugfs and not the existing perf tools for debugging?
> 

The perf doesn't match our device as we've analyzed.

For the tune function it doesn't do the sampling at all.
User specifys one link parameter and reads its current value or set
the desired one. The process is static. We didn't find a
way to adapt to perf.

For the trace function, we may barely adapt to the perf framework
but it doesn't seems like a better choice. We have our own format
of data and don't need perf doing the parsing, and we'll get extra
information added by perf as well. The settings through perf tools
won't satisfy our needs, we cannot present available settings
(filter BDF number, TLP types, buffer controls) to
the user and user cannot set in a friendly way. For example,
we cannot count on perf to decode the usual format BDF number like
<domain>:<bus>:<dev>.<fn>, which user can use filter the TLP
headers.

So we intended to make the operation of this driver a bit like
ftrace. user sets the control settings through control files
and get the result through files as well. No additional tools
is necessay. A user space tool is necessary if we use a character
device or misc device for implementing this. The trace data maybe
hundreds of megabytes, and debugfs file can just satisfy it.

Thanks,
Yicong