From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Huacai Chen <chenhuacai@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>
Subject: Re: [PATCH V2] irqchip: Make irqchip_init() usable on pure ACPI systems
Date: Wed, 28 Sep 2022 08:20:57 +0800 [thread overview]
Message-ID: <01b9d198-929a-45ea-2e94-3d0956aee2b7@loongson.cn> (raw)
In-Reply-To: <20220927124557.3246737-1-chenhuacai@loongson.cn>
On 09/27/2022 08:45 PM, Huacai Chen wrote:
> Pure ACPI system (e.g., LoongArch) doesn't select OF and OF_IRQ, but it
> still need a non-empty irqchip_init(). So, change the IRQCHIP dependency
> from OF_IRQ to (OF_IRQ || ACPI_GENERIC_GSI), and then define an empty
> inline of_irq_init() in the !CONFIG_OF_IRQ case, so as to make the non-
> empty irqchip_init() be usable on pure ACPI systems.
>
> Without this patch we get such errors:
>
> [ 0.000000] NR_IRQS: 576, nr_irqs: 576, preallocated irqs: 16
> [ 0.000000] Kernel panic - not syncing: IPI IRQ mapping failed
> [ 0.000000] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 6.0.0-rc6+ #2189
> [ 0.000000] Hardware name: Loongson Loongson-3A5000-7A1000-1w-CRB/Loongson-LS3A5000-7A1000-1w-CRB, BIOS vUDK2018-LoongArch-V2.0.pre-beta8 08/18/2022
> [ 0.000000] Stack : 0000000000000000 9000000000fa4388 900000000140c000 900000000140fb70
> [ 0.000000] 0000000000000000 900000000140fb70 90000000012f4aa0 900000000140fa98
> [ 0.000000] 900000000140fa0c 900000008140f9ff 0000000000000030 0000000000000005
> [ 0.000000] 900000000578f708 0000000004750000 0000000000000000 00000000ffffdfff
> [ 0.000000] 0000000000000000 0000000000000000 0000000000000030 000000000000002f
> [ 0.000000] 900000000141f000 0000000004750000 9000000001427348 00000000000000b0
> [ 0.000000] 90000000012f4aa0 0000000000000004 0000000000000000 9000000001020000
> [ 0.000000] 9000000005781b80 9000000005781ba9 0000000000000000 9000000001315e30
> [ 0.000000] 900000000129a3b0 9000000000222b64 0000000000000000 00000000000000b0
> [ 0.000000] 0000000000000004 0000000000000000 0000000000070000 0000000000000800
> [ 0.000000] ...
> [ 0.000000] Call Trace:
> [ 0.000000] [<9000000000222b64>] show_stack+0x24/0x124
> [ 0.000000] [<9000000000fa4388>] dump_stack_lvl+0x60/0x88
> [ 0.000000] [<9000000000f9965c>] panic+0x130/0x2f8
> [ 0.000000] [<9000000000fd4324>] init_IRQ+0xa8/0x240
> [ 0.000000] [<9000000000fd0b38>] start_kernel+0x488/0x5f0
> [ 0.000000] [<9000000000fb10c4>] kernel_entry+0xc4/0xc8
> [ 0.000000]
> [ 0.000000] ---[ end Kernel panic - not syncing: IPI IRQ mapping failed ]---
>
I am also experiencing the same problem with the latest kernel
on LoongArch, it works well with this patch.
Tested-by: Tiezhu Yang <yangtiezhu@loongson.cn>
next prev parent reply other threads:[~2022-09-28 0:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 12:45 [PATCH V2] irqchip: Make irqchip_init() usable on pure ACPI systems Huacai Chen
2022-09-28 0:20 ` Tiezhu Yang [this message]
2022-09-28 13:37 ` [irqchip: irq/irqchip-next] " irqchip-bot for Huacai Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01b9d198-929a-45ea-2e94-3d0956aee2b7@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.