Re: [PATCH v2 0/7] platform/x86: dell-wmi-sysman: Various error-handling and robustness fixes

From: Hans de Goede <hdegoede@redhat.com>
To: Mark Gross <mgross@linux.intel.com>,
	Andy Shevchenko <andy@infradead.org>
Cc: Mario Limonciello <mario.limonciello@dell.com>,
	Divya Bharathi <Divya_Bharathi@dell.com>,
	Alexander Naumann <alexandernaumann@gmx.de>,
	platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 0/7] platform/x86: dell-wmi-sysman: Various error-handling and robustness fixes
Date: Sun, 21 Mar 2021 17:41:52 +0100	[thread overview]
Message-ID: <01d018aa-9b78-afff-5268-976a55c7117c@redhat.com> (raw)
In-Reply-To: <20210321115901.35072-1-hdegoede@redhat.com>

Hi,

On 3/21/21 12:58 PM, Hans de Goede wrote:
> Hi All,
> 
> There have been several bug-reports about crashes related to the
> dell-wmi-sysman module:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1936171
> https://bugzilla.kernel.org/show_bug.cgi?id=211895
> https://bugs.archlinux.org/task/69702
> 
> Here is v2 of my series with a bunch of fixes for NULL pointer derefs,
> double-frees, etc. which fixes this.
> 
> New in v2:
> -New patch: "platform/x86: dell-wmi-sysman: Fix crash caused by calling 
> kset_unregister twice" which addresses the direct-cause of
> the crash.  Note that the crash was already fixed in v1 because
> that removed the code-path where kset_unregister ended up being
> called twice.
> 
> -Dropped: "platform/x86: dell-wmi-sysman: Make init_bios_attributes() 
> ACPI object parsing more robust". This needs more testing / discussion
> and is not necessary to fix the boot-failure which people are seeing.

I've added this series to the pdx86/review-hans and pdx86/fixes branches,
so it should show up in linux-next soon and it will also be included
in my next pull-req to Linus for 5.12.

Regards,

Hans

> Hans de Goede (7):
>   platform/x86: dell-wmi-sysman: Fix crash caused by calling
>     kset_unregister twice
>   platform/x86: dell-wmi-sysman: Fix possible NULL pointer deref on exit
>   platform/x86: dell-wmi-sysman: Make it safe to call
>     exit_foo_attributes() multiple times
>   platform/x86: dell-wmi-sysman: Fix release_attributes_data() getting
>     called twice on init_bios_attributes() failure
>   platform/x86: dell-wmi-sysman: Cleanup sysman_init() error-exit
>     handling
>   platform/x86: dell-wmi-sysman: Make sysman_init() return -ENODEV of
>     the interfaces are not found
>   platform/x86: dell-wmi-sysman: Cleanup
>     create_attributes_level_sysfs_files()
> 
>  .../dell/dell-wmi-sysman/enum-attributes.c    |  3 +
>  .../x86/dell/dell-wmi-sysman/int-attributes.c |  3 +
>  .../dell/dell-wmi-sysman/passobj-attributes.c |  3 +
>  .../dell/dell-wmi-sysman/string-attributes.c  |  3 +
>  .../x86/dell/dell-wmi-sysman/sysman.c         | 84 +++++++------------
>  5 files changed, 44 insertions(+), 52 deletions(-)
> 