From: Alexander Wetzel <alexander@wetzel-home.de>
To: linux-wireless@vger.kernel.org
Cc: Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH] wifi: mac80211: convert PS buffering into iTXQ
Date: Tue, 1 Nov 2022 09:18:05 +0100 [thread overview]
Message-ID: <02494022-6f02-22ba-eb9e-f57384c9238d@wetzel-home.de> (raw)
In-Reply-To: <20221031211815.6666-1-alexander@wetzel-home.de>
> @@ -3773,6 +3577,13 @@ struct sk_buff *ieee80211_tx_dequeue(struct ieee80211_hw *hw,
> ieee80211_free_txskb(&local->hw, skb);
> goto begin;
> }
> + } else if (vif->txq == txq &&
> + vif->type == NL80211_IFTYPE_AP &&
> + atomic_read(&tx.sdata->bss->ps.num_sta_ps)) {
> + info->flags |= IEEE80211_TX_CTL_SEND_AFTER_DTIM;
> +
> + if (ieee80211_hw_check(&tx.local->hw, QUEUE_CONTROL))
> + info->hw_queue = tx.sdata->vif.cab_queue;
I forgot to drop the two lines above.
vif.cab_queue is also set in ieee80211_get_txq(), making these lines
redundant. (As standalone they would be wrong and not always setting the
flag when needed.)
Since I'm sure there will be more issues I won't submit a new patch
immediately.
Alexander
next prev parent reply other threads:[~2022-11-01 8:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 21:18 [PATCH] wifi: mac80211: convert PS buffering into iTXQ Alexander Wetzel
2022-11-01 8:18 ` Alexander Wetzel [this message]
2022-11-06 0:17 kernel test robot
2022-11-07 8:00 ` Dan Carpenter
2022-11-07 13:52 ` Alexander Wetzel
2022-11-07 13:59 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02494022-6f02-22ba-eb9e-f57384c9238d@wetzel-home.de \
--to=alexander@wetzel-home.de \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.