From: Eric Sandeen <sandeen@sandeen.net>
To: Carlos Maiolino <cmaiolino@redhat.com>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/4] xfs: Use variable-size array for nameval in xfs_attr_sf_entry
Date: Mon, 31 Aug 2020 09:53:21 -0500 [thread overview]
Message-ID: <029949dc-6f6b-7083-0dc7-85961f728776@sandeen.net> (raw)
In-Reply-To: <20200831130423.136509-2-cmaiolino@redhat.com>
On 8/31/20 8:04 AM, Carlos Maiolino wrote:
> #define XFS_ATTR_SF_ENTSIZE_MAX /* max space for name&value */ \
> - ((1 << (NBBY*(int)sizeof(uint8_t))) - 1)
> + (1 << (NBBY*(int)sizeof(uint8_t)))
This probably is not correct. :)
This would cut the max size of attr (name+value) in half.
-Eric
next prev parent reply other threads:[~2020-08-31 14:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 13:04 [PATCH 0/4] Clean up xfs_attr_sf_entry Carlos Maiolino
2020-08-31 13:04 ` [PATCH 1/4] xfs: Use variable-size array for nameval in xfs_attr_sf_entry Carlos Maiolino
2020-08-31 14:53 ` Eric Sandeen [this message]
2020-08-31 14:54 ` Eric Sandeen
2020-08-31 15:31 ` Darrick J. Wong
2020-09-02 11:13 ` Carlos Maiolino
2020-08-31 13:04 ` [PATCH 2/4] xfs: Convert xfs_attr_sf macros to inline functions Carlos Maiolino
2020-08-31 15:34 ` Darrick J. Wong
2020-09-01 7:43 ` Carlos Maiolino
2020-08-31 13:04 ` [PATCH 3/4] xfs: remove typedef xfs_attr_sf_entry_t Carlos Maiolino
2020-08-31 15:34 ` Darrick J. Wong
2020-08-31 13:04 ` [PATCH 4/4] xfs: Remove typedef xfs_attr_shortform_t Carlos Maiolino
2020-08-31 15:35 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=029949dc-6f6b-7083-0dc7-85961f728776@sandeen.net \
--to=sandeen@sandeen.net \
--cc=cmaiolino@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.