From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Claudio Fontana" <cfontana@suse.de>
Subject: Re: [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation
Date: Sun, 24 Jan 2021 01:32:56 +0100 [thread overview]
Message-ID: <02ef2d7f-ac16-af21-a002-bc2165646dfc@redhat.com> (raw)
In-Reply-To: <fcb116d8-8701-90cc-fabd-85983740f74b@redhat.com>
On 1/23/21 7:10 PM, Paolo Bonzini wrote:
> On 22/01/21 21:44, Philippe Mathieu-Daudé wrote:
>> Beside a CPU device, user-mode emulation doesn't access
>> anything else from qdev subsystem.
>>
>> Tools don't need anything from qdev.
>
> I prefer to avoid stubs. So if this patch can simply be dropped with no
> effects on 10-12, that's nicer for me.
The alternative is ugly:
-- >8 --
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index cefc5eaa0a9..d09f32e38d6 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -950,7 +950,9 @@ static void device_finalize(Object *obj)
if (dev->pending_deleted_event) {
g_assert(dev->canonical_path);
+#ifdef CONFIG_USER_ONLY
qapi_event_send_device_deleted(!!dev->id, dev->id,
dev->canonical_path);
+#endif
g_free(dev->canonical_path);
dev->canonical_path = NULL;
}
---
Maybe wrapping it in an inlined function?
next prev parent reply other threads:[~2021-01-24 0:34 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 20:44 [PATCH v2 00/12] buildsys: Do not build various objects if not necessary Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 01/12] configure: Only check for audio drivers if system-mode is selected Philippe Mathieu-Daudé
2021-01-25 14:52 ` Alex Bennée
2021-01-22 20:44 ` [PATCH v2 02/12] tests/meson: Only build softfloat objects if TCG " Philippe Mathieu-Daudé
2021-01-23 12:19 ` Claudio Fontana
2021-01-25 15:05 ` Alex Bennée
2021-01-22 20:44 ` [PATCH v2 03/12] pc-bios/meson: Only install EDK2 blob firmwares with system emulation Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 04/12] meson: Do not build optional libraries by default Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 05/12] meson: Restrict block subsystem processing Philippe Mathieu-Daudé
2021-01-25 12:15 ` Kevin Wolf
2021-01-25 18:51 ` Paolo Bonzini
2021-01-22 20:44 ` [PATCH v2 06/12] meson: Merge trace_events_subdirs array Philippe Mathieu-Daudé
2021-01-23 12:29 ` Claudio Fontana
2021-01-22 20:44 ` [PATCH v2 07/12] meson: Restrict some trace event directories to user/system emulation Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 08/12] meson: Restrict emulation code Philippe Mathieu-Daudé
2021-01-25 15:09 ` Philippe Mathieu-Daudé
2021-01-25 15:12 ` Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 09/12] qapi/meson: Restrict qdev code to system-mode emulation Philippe Mathieu-Daudé
2021-01-23 18:10 ` Paolo Bonzini
2021-01-24 0:32 ` Philippe Mathieu-Daudé [this message]
2021-01-26 15:46 ` Paolo Bonzini
2021-01-22 20:44 ` [PATCH v2 10/12] qapi/meson: Remove QMP from user-mode emulation Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 11/12] qapi/meson: Restrict system-mode specific modules Philippe Mathieu-Daudé
2021-01-22 20:44 ` [PATCH v2 12/12] qapi/meson: Restrict UI module to system emulation and tools Philippe Mathieu-Daudé
2021-01-23 18:11 ` [PATCH v2 00/12] buildsys: Do not build various objects if not necessary Paolo Bonzini
2021-01-26 14:57 ` Alex Bennée
2021-01-26 15:28 ` Philippe Mathieu-Daudé
2021-01-26 16:09 ` Markus Armbruster
2021-01-26 19:38 ` Philippe Mathieu-Daudé
2021-01-27 8:42 ` Markus Armbruster
2021-01-29 8:22 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02ef2d7f-ac16-af21-a002-bc2165646dfc@redhat.com \
--to=philmd@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cfontana@suse.de \
--cc=ehabkost@redhat.com \
--cc=laurent@vivier.eu \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.