Re: [PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kartik Agarwala <agarwala.kartik@gmail.com>,
	lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: patches@opensource.cirrus.com, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH] ASoC: dt-bindings: wm8974: Convert to dtschema
Date: Mon, 25 Mar 2024 20:30:16 +0100	[thread overview]
Message-ID: <02fc496c-caac-4434-8e18-229074733b1c@linaro.org> (raw)
In-Reply-To: <20240325181943.116733-1-agarwala.kartik@gmail.com>

On 25/03/2024 19:19, Kartik Agarwala wrote:
> Convert WM8974 audio CODEC bindings from text to dtschema.
> 
> Signed-off-by: Kartik Agarwala <agarwala.kartik@gmail.com>

Thank you for your patch. There are no DTS users of this binding, so
while such conversions are useful, they have significantly smaller
impact. In the future, please consider converting bindings from active
platforms (arm64 defconfig, arm multi_v7). This would have significantly
bigger impact.

See also:
https://lore.kernel.org/all/6552bcb8-e046-4882-91da-1094fff3d239@linaro.org/

> ---
>  .../devicetree/bindings/sound/wlf,wm8974.txt  | 15 -------
>  .../devicetree/bindings/sound/wlf,wm8974.yaml | 41 +++++++++++++++++++
>  2 files changed, 41 insertions(+), 15 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/wlf,wm8974.yaml
> 

...

> +  "#sound-dai-cells":
> +    const: 0
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        codec@1a {
> +            compatible = "wlf,wm8974";
> +            reg = <0x1a>;

In the future for other patches like this, make example complete, so add
a dai-cells also here.

No need to resend just for that.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof