From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: Cleber Rosa <crosa@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Hanna Reitz <hreitz@redhat.com>,
qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PATCH v4 6/8] iotests/300: avoid abnormal shutdown race condition
Date: Thu, 14 Oct 2021 20:06:15 +0300 [thread overview]
Message-ID: <03050cee-603a-9199-9f24-59cfa6a7188f@virtuozzo.com> (raw)
In-Reply-To: <20211013215748.2154908-7-jsnow@redhat.com>
14.10.2021 00:57, John Snow wrote:
> Wait for the destination VM to close itself instead of racing to shut it
> down first, which produces different error log messages from AQMP
> depending on precisely when we tried to shut it down.
>
> (For example: We may try to issue 'quit' immediately prior to the target
> VM closing its QMP socket, which will cause an ECONNRESET error to be
> logged. Waiting for the VM to exit itself avoids the race on shutdown
> behavior.)
>
> Reported-by: Hanna Reitz<hreitz@redhat.com>
> Signed-off-by: John Snow<jsnow@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-10-14 17:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 21:57 [PATCH v4 0/8] Switch iotests to using Async QMP John Snow
2021-10-13 21:57 ` [PATCH v4 1/8] python/machine: remove has_quit argument John Snow
2021-10-13 21:57 ` [PATCH v4 2/8] python/machine: Handle QMP errors on close more meticulously John Snow
2021-10-13 21:57 ` [PATCH v4 3/8] python/aqmp: Remove scary message John Snow
2021-10-13 21:57 ` [PATCH v4 4/8] iotests: Accommodate async QMP Exception classes John Snow
2021-10-13 21:57 ` [PATCH v4 5/8] iotests: Conditionally silence certain AQMP errors John Snow
2021-10-13 21:57 ` [PATCH v4 6/8] iotests/300: avoid abnormal shutdown race condition John Snow
2021-10-14 17:06 ` Vladimir Sementsov-Ogievskiy [this message]
2021-10-25 12:10 ` Hanna Reitz
2021-10-25 13:20 ` Hanna Reitz
2021-10-26 17:07 ` John Snow
2021-10-27 7:44 ` Hanna Reitz
2021-10-13 21:57 ` [PATCH v4 7/8] python/aqmp: Create sync QMP wrapper for iotests John Snow
2021-10-13 21:57 ` [PATCH v4 8/8] python, iotests: replace qmp with aqmp John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03050cee-603a-9199-9f24-59cfa6a7188f@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.