From: Jan Beulich <jbeulich@suse.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: Paul Durrant <paul@xen.org>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/4] VT-d: consider hidden devices when unmapping
Date: Thu, 16 Sep 2021 10:31:30 +0200 [thread overview]
Message-ID: <030c4cf1-f361-1d36-c61f-28537a359c08@suse.com> (raw)
In-Reply-To: <BN9PR11MB5433706BE0A6C4B915D3707D8CDC9@BN9PR11MB5433.namprd11.prod.outlook.com>
On 16.09.2021 10:18, Tian, Kevin wrote:
>> @@ -1737,23 +1737,33 @@ static int domain_context_unmap(struct d
>> return ret;
>>
>> /*
>> - * if no other devices under the same iommu owned by this domain,
>> - * clear iommu in iommu_bitmap and clear domain_id in domid_bitmp
>> + * If no other devices under the same iommu owned by this domain,
>> + * clear iommu in iommu_bitmap and clear domain_id in domid_bitmap.
>
> what is changed above?
A style and a spelling correction: Capital letter at the start and
a missing 'a' in domid_bitmap.
>> */
>> - for_each_pdev ( domain, pdev )
>> + for ( found = false; ; domain = dom_xen )
>
> honesty speaking I had to read several times to understand the break
> condition of this loop. It'd be easier to understand if putting for_each_
> pdev(){} into a function and then:
>
> found = func(domain);
> if (!found && is_hardware_domain(domain))
> found = func(dom_xen);
Can do so, sure.
Jan
next prev parent reply other threads:[~2021-09-16 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 9:11 [PATCH 0/4] IOMMU/PCI: respect device specifics Jan Beulich
2021-09-15 9:12 ` [PATCH 1/4] VT-d: defer "no DRHD" check when (un)mapping devices Jan Beulich
2021-09-16 8:05 ` Tian, Kevin
2021-09-15 9:12 ` [PATCH 2/4] VT-d: consider hidden devices when unmapping Jan Beulich
2021-09-16 8:18 ` Tian, Kevin
2021-09-16 8:31 ` Jan Beulich [this message]
2021-09-15 9:13 ` [PATCH 3/4] VT-d: skip IOMMU bitmap cleanup for phantom devices Jan Beulich
2021-09-16 8:19 ` Tian, Kevin
2021-09-15 9:13 ` [PATCH 4/4] AMD/IOMMU: consider hidden devices when flushing device I/O TLBs Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=030c4cf1-f361-1d36-c61f-28537a359c08@suse.com \
--to=jbeulich@suse.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.