From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: wangweidong.a@awinic.com, lgirdwood@gmail.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, perex@perex.cz, tiwai@suse.com,
rf@opensource.cirrus.com, herve.codina@bootlin.com,
shumingf@realtek.com, rdunlap@infradead.org, 13916275206@139.com,
ryans.lee@analog.com, linus.walleij@linaro.org,
ckeepax@opensource.cirrus.com, yijiangtao@awinic.com,
liweilei@awinic.com, colin.i.king@gmail.com, trix@redhat.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, zhangjianming@awinic.com
Subject: Re: [PATCH V1 3/3] ASoC: codecs: Add aw87390 amplifier driver
Date: Mon, 4 Sep 2023 15:02:31 +0200 [thread overview]
Message-ID: <0360d279-b535-f3f2-9651-07dff2df2e37@linaro.org> (raw)
In-Reply-To: <598febde-429e-4319-98d4-4306a7f8bfe8@sirena.org.uk>
On 04/09/2023 14:30, Mark Brown wrote:
> On Mon, Sep 04, 2023 at 02:17:43PM +0200, Krzysztof Kozlowski wrote:
>> On 04/09/2023 13:46, wangweidong.a@awinic.com wrote:
>
>>> + ret = regmap_read(regmap, AW87390_ID_REG, &chip_id);
>>> + if (ret) {
>>> + dev_err(&i2c->dev, "%s read chipid error. ret = %d\n", __func__, ret);
>>> + return ret;
>>> + }
>
>>> + if (chip_id != AW87390_CHIP_ID) {
>>> + dev_err(&i2c->dev, "unsupported device\n");
>
>> Why? The compatible tells it cannot be anything else.
>
> This is very common good practice, as well as validating communication
No, it is neither common nor good. The kernel's job is not to verify the
supplied DTS. Rob also made here a point:
https://lore.kernel.org/all/CAL_Jsq+wcrOjh7+0c=mrg+Qz6dbhOUE-VEeQ4FoWC3Y7ENoyfQ@mail.gmail.com/
> with the device it verifies that the device descrbied in the DT is the
> one that is actually present in the system. This might create hassle
> down the line if there is a backwards compatible upgrade but that's much
> rarer for this class of hardware than cut'n'pasting of device trees.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-04 13:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 11:46 [PATCH V1 0/3] ASoC: codecs: Add aw87390 amplifier driver wangweidong.a
2023-09-04 11:46 ` [PATCH V1 1/3] ASoC: dt-bindings: Add schema for "awinic,aw87390" wangweidong.a
2023-09-04 12:14 ` Krzysztof Kozlowski
2023-09-05 3:31 ` wangweidong.a
2023-09-05 6:33 ` Krzysztof Kozlowski
2023-09-04 11:46 ` [PATCH V1 2/3] ASoC: codecs: Add code for bin parsing compatible with aw87390 wangweidong.a
2023-09-04 11:46 ` [PATCH V1 3/3] ASoC: codecs: Add aw87390 amplifier driver wangweidong.a
2023-09-04 12:17 ` Krzysztof Kozlowski
2023-09-04 12:30 ` Mark Brown
2023-09-04 13:02 ` Krzysztof Kozlowski [this message]
2023-09-04 14:54 ` Mark Brown
2023-09-04 20:26 ` Linus Walleij
2023-09-05 6:03 ` wangweidong.a
2023-09-04 20:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0360d279-b535-f3f2-9651-07dff2df2e37@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=13916275206@139.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=herve.codina@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liweilei@awinic.com \
--cc=perex@perex.cz \
--cc=rdunlap@infradead.org \
--cc=rf@opensource.cirrus.com \
--cc=robh+dt@kernel.org \
--cc=ryans.lee@analog.com \
--cc=shumingf@realtek.com \
--cc=tiwai@suse.com \
--cc=trix@redhat.com \
--cc=wangweidong.a@awinic.com \
--cc=yijiangtao@awinic.com \
--cc=zhangjianming@awinic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.