From: Julien Grall <julien.grall@arm.com>
To: Bhupinder Thakur <bhupinder.thakur@linaro.org>,
xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH 02/12 v3] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h
Date: Mon, 22 May 2017 13:21:35 +0100 [thread overview]
Message-ID: <03e1d7ca-16a5-dc77-c944-3a5e7807f4eb@arm.com> (raw)
In-Reply-To: <1494426293-32481-2-git-send-email-bhupinder.thakur@linaro.org>
Hi Bhupinder,
On 10/05/17 15:24, Bhupinder Thakur wrote:
> diff --git a/xen/include/asm-arm/vgic.h b/xen/include/asm-arm/vgic.h
> index c838298..75c716e 100644
> --- a/xen/include/asm-arm/vgic.h
> +++ b/xen/include/asm-arm/vgic.h
> @@ -172,18 +172,6 @@ static inline int REG_RANK_NR(int b, uint32_t n)
> }
> }
>
> -/*
> - * 64 bits registers are only supported on platform with 64-bit long.
> - * This is also allow us to optimize the 32 bit case by using
> - * unsigned long rather than uint64_t
> - */
> -#if BITS_PER_LONG == 64
> -VGIC_REG_HELPERS(64, 0x7);
> -#endif
> -VGIC_REG_HELPERS(32, 0x3);
> -
> -#undef VGIC_REG_HELPERS
> -
Why this is moved out here? And not in patch #1?
> enum gic_sgi_mode;
>
> /*
> diff --git a/xen/include/asm-arm/vreg.h b/xen/include/asm-arm/vreg.h
> index 1442c58..e127114 100644
> --- a/xen/include/asm-arm/vreg.h
> +++ b/xen/include/asm-arm/vreg.h
[...]
> -{ \
> - unsigned long tmp = *reg; \
> - \
> - vgic_reg_clearbits(&tmp, bits, info->gpa & offmask, \
> - info->dabt.size); \
> - \
> - *reg = tmp; \
> +#define DEFINE_VREG_REG_HELPERS(sz, offmask) \
Nack. There are no reason to rename the name of the macro more than
s/vgic/vreg/. It also makes to patch diff more difficult to read.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-05-22 12:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 14:24 [PATCH 01/12 v3] xen/arm: vpl011: Move vgic register access functions to vreg.h Bhupinder Thakur
2017-05-10 14:24 ` [PATCH 02/12 v3] xen/arm: vpl011: Define generic vreg_reg* access functions in vreg.h Bhupinder Thakur
2017-05-22 12:21 ` Julien Grall [this message]
2017-05-23 6:14 ` Bhupinder Thakur
2017-05-10 14:24 ` [PATCH 03/12 v3] xen/arm: vpl011: Add pl011 uart emulation in Xen Bhupinder Thakur
2017-05-16 22:42 ` Stefano Stabellini
2017-05-22 14:24 ` Julien Grall
2017-05-26 13:42 ` Bhupinder Thakur
2017-05-29 7:13 ` Bhupinder Thakur
2017-05-29 18:26 ` Julien Grall
2017-06-01 13:34 ` Bhupinder Thakur
2017-06-01 13:56 ` Julien Grall
2017-06-01 10:33 ` Bhupinder Thakur
2017-06-01 12:42 ` Julien Grall
2017-05-22 12:18 ` [PATCH 01/12 v3] xen/arm: vpl011: Move vgic register access functions to vreg.h Julien Grall
2017-05-22 12:56 ` Bhupinder Thakur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03e1d7ca-16a5-dc77-c944-3a5e7807f4eb@arm.com \
--to=julien.grall@arm.com \
--cc=bhupinder.thakur@linaro.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.