All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org
Subject: Re: [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git
Date: Tue, 12 Nov 2019 10:15:44 +0100	[thread overview]
Message-ID: <049148d5-0a35-e8bf-4a8b-714a3f1fb9d1@redhat.com> (raw)
In-Reply-To: <20191112034532.69079-1-aik@ozlabs.ru>

On 12/11/19 04:45, Alexey Kardashevskiy wrote:
> Recent git versions support worktrees where .git is not a directory but
> a file with a path to the .git repository; however the get_maintainer.pl
> script only recognises the .git directory, let's fix it.
> 
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  scripts/get_maintainer.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> index 71415e3c7061..27991eb1cfb4 100755
> --- a/scripts/get_maintainer.pl
> +++ b/scripts/get_maintainer.pl
> @@ -81,7 +81,7 @@ my %VCS_cmds;
>  
>  my %VCS_cmds_git = (
>      "execute_cmd" => \&git_execute_cmd,
> -    "available" => '(which("git") ne "") && (-d ".git")',
> +    "available" => '(which("git") ne "") && (-e ".git")',
>      "find_signers_cmd" =>
>  	"git log --no-color --follow --since=\$email_git_since " .
>  	    '--format="GitCommit: %H%n' .
> 

Queued, thanks.

Paolo



      parent reply	other threads:[~2019-11-12  9:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  3:45 [PATCH qemu] scripts: Detect git worktrees for get_maintainer.pl --git Alexey Kardashevskiy
2019-11-12  8:50 ` Stefano Garzarella
2019-11-12  8:53 ` Greg Kurz
2019-11-12  9:15 ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=049148d5-0a35-e8bf-4a8b-714a3f1fb9d1@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.