Re: [PATCH] platform/x86: amd-pmc: Add a message to print resume time info

From: Hans de Goede <hdegoede@redhat.com>
To: Sanket Goswami <Sanket.Goswami@amd.com>,
	Shyam-sundar.S-k@amd.com, mgross@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: amd-pmc: Add a message to print resume time info
Date: Tue, 28 Sep 2021 13:31:08 +0200	[thread overview]
Message-ID: <04b3b748-06a3-fe35-7a9e-30b5deff18d9@redhat.com> (raw)
In-Reply-To: <20210921120020.19454-1-Sanket.Goswami@amd.com>

Hi,

On 9/21/21 2:00 PM, Sanket Goswami wrote:
> Add a message to print the resume time information obtained from the
> smu_metrics structure.
> 
> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/amd-pmc.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
> index bc7c4498067b..27c04ff57ffb 100644
> --- a/drivers/platform/x86/amd-pmc.c
> +++ b/drivers/platform/x86/amd-pmc.c
> @@ -174,6 +174,8 @@ static int smu_fw_info_show(struct seq_file *s, void *unused)
>  		   "Unknown/Fail");
>  	seq_printf(s, "Time (in us) to S0i3: %lld\n", table.timeentering_s0i3_lastcapture);
>  	seq_printf(s, "Time (in us) in S0i3: %lld\n", table.timein_s0i3_lastcapture);
> +	seq_printf(s, "Time (in us) to resume from S0i3: %lld\n",
> +		   table.timeto_resume_to_os_lastcapture);
>  
>  	seq_puts(s, "\n=== Active time (in us) ===\n");
>  	for (idx = 0 ; idx < SOC_SUBSYSTEM_IP_MAX ; idx++) {
> 