From: Paolo Bonzini <pbonzini@redhat.com>
To: Pavel Dovgalyuk <pavel.dovgalyuk@ispras.ru>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org, crosa@redhat.com, f4bug@amsat.org
Subject: Re: [PATCH v3 4/9] replay: simplify async event processing
Date: Thu, 26 May 2022 11:40:59 +0200 [thread overview]
Message-ID: <04b4715c-e5e8-038e-e3e1-179ff9085d3a@redhat.com> (raw)
In-Reply-To: <165355472374.533615.18197241124455918315.stgit@pasha-ThinkPad-X280>
On 5/26/22 10:45, Pavel Dovgalyuk wrote:
> +
> +typedef enum ReplayAsyncEventKind {
> + REPLAY_ASYNC_EVENT_BH,
> + REPLAY_ASYNC_EVENT_BH_ONESHOT,
> + REPLAY_ASYNC_EVENT_INPUT,
> + REPLAY_ASYNC_EVENT_INPUT_SYNC,
> + REPLAY_ASYNC_EVENT_CHAR_READ,
> + REPLAY_ASYNC_EVENT_BLOCK,
> + REPLAY_ASYNC_EVENT_NET,
> + REPLAY_ASYNC_COUNT
> +} ReplayAsyncEventKind;
> +
> /* Any changes to order/number of events will need to bump REPLAY_VERSION */
> enum ReplayEvents {
> /* for instruction event */
> @@ -22,6 +35,7 @@ enum ReplayEvents {
> EVENT_EXCEPTION,
> /* for async events */
> EVENT_ASYNC,
> + EVENT_ASYNC_LAST = EVENT_ASYNC + REPLAY_ASYNC_COUNT - 1,
Why not unify the two enums into one?
Paolo
next prev parent reply other threads:[~2022-05-26 9:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 8:45 [PATCH v3 0/9] Record/replay refactoring and stuff Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 1/9] replay: fix event queue flush for qemu shutdown Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 2/9] replay: notify vCPU when BH is scheduled Pavel Dovgalyuk
2022-05-26 9:37 ` Paolo Bonzini
2022-05-26 9:51 ` Pavel Dovgalyuk
2022-05-26 12:10 ` Paolo Bonzini
2022-05-27 8:45 ` Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 3/9] replay: rewrite async event handling Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 4/9] replay: simplify async event processing Pavel Dovgalyuk
2022-05-26 9:40 ` Paolo Bonzini [this message]
2022-05-26 9:53 ` Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 5/9] docs: convert docs/devel/replay page to rst Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 6/9] docs: move replay docs to docs/system/replay.rst Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 7/9] tests/avocado: update replay_linux test Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 8/9] tests/avocado: add replay Linux tests for virtio machine Pavel Dovgalyuk
2022-05-26 8:45 ` [PATCH v3 9/9] tests/avocado: add replay Linux test for Aarch64 machines Pavel Dovgalyuk
2022-05-26 9:42 ` [PATCH v3 0/9] Record/replay refactoring and stuff Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b4715c-e5e8-038e-e3e1-179ff9085d3a@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=pavel.dovgalyuk@ispras.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.