From: Dan Carpenter <dan.carpenter@linaro.org>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Rengarajan S <rengarajan.s@microchip.com>,
Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
Tharun Kumar P <tharunkumar.pasumarthi@microchip.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] serial: 8250_pci1xxxx: fix off by one in pci1xxxx_process_read_data()
Date: Wed, 10 Jan 2024 23:19:28 +0300 [thread overview]
Message-ID: <05465217-174e-4888-a6ab-6251f4a9920b@moroto.mountain> (raw)
In-Reply-To: <20240110144605.2a8813d4bfaff1a55edb9938@hugovil.com>
On Wed, Jan 10, 2024 at 02:46:05PM -0500, Hugo Villeneuve wrote:
> Hi,
> it is not simply a matter of adding "fix" to the title.
>
> You must explain what and why vs. how.
>
> Please see:
> https://cbea.ms/git-commit/#why-not-how
>
> for some guidelines on writing a good commit message.
>
If you can't understand why a buffer overflow is bad then I honestly
don't know what to say...
When I was a newbie, I encountered a driver which was written in
terrible style. And I thought why do people allow it??? This is
garbage and it's messing up the Linux kernel with its bad style.
But after I got older, I realized that he was the only person with that
hardware and the only person who cared about it. If I started fighting
with him about style then he would leave. He was a quirky guy with bad
taste but he was still making useful contributions so it was better to
tolerate him.
These days I'm the old quirky guy. If you want to fight with me about
commit messages, that's fine. I can easily just add you to my list of
subsystems which only receive bug reports instead of patches. (I think
only BPF is on the list currently because it's annoying to track the
bpf vs bpf-next tree).
Feel free to re-write this patch however you want and give me
Reported-by credit.
regards,
dan carpenter
next prev parent reply other threads:[~2024-01-10 20:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-10 19:25 [PATCH v2] serial: 8250_pci1xxxx: fix off by one in pci1xxxx_process_read_data() Dan Carpenter
2024-01-10 19:46 ` Hugo Villeneuve
2024-01-10 20:07 ` Greg Kroah-Hartman
2024-01-10 20:19 ` Dan Carpenter [this message]
2024-01-10 22:41 ` Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05465217-174e-4888-a6ab-6251f4a9920b@moroto.mountain \
--to=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hugo@hugovil.com \
--cc=jirislaby@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rengarajan.s@microchip.com \
--cc=tharunkumar.pasumarthi@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.