Re: [PATCH] platform/x86: touchscreen_dmi: Handle device properties with software node API

From: Hans de Goede <hdegoede@redhat.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Mark Gross <mgross@linux.intel.com>,
	linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: touchscreen_dmi: Handle device properties with software node API
Date: Thu, 4 Mar 2021 15:39:25 +0100	[thread overview]
Message-ID: <059af9be-46c3-11ee-a9ff-3384e307ed58@redhat.com> (raw)
In-Reply-To: <20210304082023.17689-1-heikki.krogerus@linux.intel.com>

Hi,

On 3/4/21 9:20 AM, Heikki Krogerus wrote:
> The old device property API (device_add_properties()) is
> going to be removed. Replacing the it with the software node
> API equivalent, device_create_managed_software_node().
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans

> ---
>  drivers/platform/x86/touchscreen_dmi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c
> index c44a6e8dceb8c..45203e333f578 100644
> --- a/drivers/platform/x86/touchscreen_dmi.c
> +++ b/drivers/platform/x86/touchscreen_dmi.c
> @@ -1355,7 +1355,7 @@ static void ts_dmi_add_props(struct i2c_client *client)
>  
>  	if (has_acpi_companion(dev) &&
>  	    !strncmp(ts_data->acpi_name, client->name, I2C_NAME_SIZE)) {
> -		error = device_add_properties(dev, ts_data->properties);
> +		error = device_create_managed_software_node(dev, ts_data->properties, NULL);
>  		if (error)
>  			dev_err(dev, "failed to add properties: %d\n", error);
>  	}
> 