From: David Sterba <dsterba@suse.com>
To: linux-btrfs@vger.kernel.org
Cc: David Sterba <dsterba@suse.com>
Subject: [PATCH 12/16] btrfs: make state preallocation more speculative in __set_extent_bit
Date: Fri, 29 Apr 2016 11:20:54 +0200 [thread overview]
Message-ID: <059f791c6bbaba72dc3c1bd6e2657aacc8552849.1461920675.git.dsterba@suse.com> (raw)
In-Reply-To: <cover.1461920675.git.dsterba@suse.com>
Similar to __clear_extent_bit, do not fail if the state preallocation
fails as we might not need it. One less BUG_ON.
Signed-off-by: David Sterba <dsterba@suse.com>
---
fs/btrfs/extent_io.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index d39e2241ceb7..8707bcc615ff 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -873,8 +873,14 @@ __set_extent_bit(struct extent_io_tree *tree, u64 start, u64 end,
bits |= EXTENT_FIRST_DELALLOC;
again:
if (!prealloc && gfpflags_allow_blocking(mask)) {
+ /*
+ * Don't care for allocation failure here because we might end
+ * up not needing the pre-allocated extent state at all, which
+ * is the case if we only have in the tree extent states that
+ * cover our input range and don't cover too any other range.
+ * If we end up needing a new extent state we allocate it later.
+ */
prealloc = alloc_extent_state(mask);
- BUG_ON(!prealloc);
}
spin_lock(&tree->lock);
--
2.7.1
next prev parent reply other threads:[~2016-04-29 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 9:20 [PATCH 00/16] Minor cleanups in GFP_NOFS flags use David Sterba
2016-04-29 9:20 ` [PATCH 01/16] btrfs: sink gfp parameter to set_extent_bits David Sterba
2016-04-29 9:20 ` [PATCH 02/16] btrfs: sink gfp parameter to clear_extent_bits David Sterba
2016-04-29 9:20 ` [PATCH 03/16] btrfs: sink gfp parameter to clear_record_extent_bits David Sterba
2016-04-29 9:20 ` [PATCH 04/16] btrfs: sink gfp parameter to clear_extent_dirty David Sterba
2016-04-29 9:20 ` [PATCH 05/16] btrfs: sink gfp parameter to set_extent_delalloc David Sterba
2016-04-29 9:20 ` [PATCH 06/16] btrfs: sink gfp parameter to set_extent_defrag David Sterba
2016-04-29 9:20 ` [PATCH 07/16] btrfs: sink gfp parameter to set_extent_new David Sterba
2016-04-29 9:20 ` [PATCH 08/16] btrfs: sink gfp parameter to set_record_extent_bits David Sterba
2016-04-29 9:20 ` [PATCH 09/16] btrfs: untangle gotos a bit in __set_extent_bit David Sterba
2016-04-29 9:20 ` [PATCH 10/16] btrfs: untangle gotos a bit in __clear_extent_bit David Sterba
2016-04-29 9:20 ` [PATCH 11/16] btrfs: untangle gotos a bit in convert_extent_bit David Sterba
2016-04-29 9:20 ` David Sterba [this message]
2016-04-29 9:20 ` [PATCH 13/16] btrfs: __set_extent_bit, try preallocation out of locked section with lighter gfp flags David Sterba
2016-04-29 10:00 ` Filipe Manana
2016-04-29 11:46 ` David Sterba
2016-04-29 9:21 ` [PATCH 14/16] btrfs: __clear_extent_bit, " David Sterba
2016-04-29 9:21 ` [PATCH 15/16] btrfs: convert_extent_bit, " David Sterba
2016-04-29 9:21 ` [PATCH 16/16] btrfs: sink gfp parameter to convert_extent_bit David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=059f791c6bbaba72dc3c1bd6e2657aacc8552849.1461920675.git.dsterba@suse.com \
--to=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.