Re: [PATCH v2 4/8] media: qcom: camss: Add new params for csid_device

From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Depeng Shao <quic_depengs@quicinc.com>,
	rfoss@kernel.org, todor.too@gmail.com, andersson@kernel.org,
	konrad.dybcio@linaro.org, mchehab@kernel.org,
	quic_yon@quicinc.com
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 4/8] media: qcom: camss: Add new params for csid_device
Date: Wed, 20 Mar 2024 15:26:28 +0000	[thread overview]
Message-ID: <05dcb857-706e-4674-8221-7d0209e6c1fb@linaro.org> (raw)
In-Reply-To: <20240320141136.26827-5-quic_depengs@quicinc.com>

On 20/03/2024 14:11, Depeng Shao wrote:
> CSID gen3 has a new register block which is named as
> CSID top, it controls the output of CSID, since the
> CSID can connect to SFE or original VFE in CSID gen3.
> The register update is moved to CSID from VFE in CSID
> gen3.
> So, adding top_base and reg_update variables in csid
> device structure for CSID gen3.

You need to define three letter acronyms (TLAs) - within reason - the 
first time you use them.

There is no concept of an "SFE" upstream - please define what the SFE is 
in the commit log "to the Sensor Front End (SFE)" then you can refer 
back to the acronym liberally.

---
bod