From: Hannes Reinecke <hare@suse.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-block@vger.kernel.org
Cc: axboe@kernel.dk
Subject: Re: [PATCH V5 5/5] f2fs: use block layer helper for show_bio_op macro
Date: Fri, 21 Jun 2019 09:39:41 +0200 [thread overview]
Message-ID: <06714e3d-be00-8425-9888-edb46c1c4185@suse.de> (raw)
In-Reply-To: <20190620175919.3273-6-chaitanya.kulkarni@wdc.com>
On 6/20/19 7:59 PM, Chaitanya Kulkarni wrote:
> Adjust the f2fs tracing code to use newly introduced block layer
> function blk_op_str() which converts the REQ_OP_XXX into the string
> XXX.
>
> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> ---
> include/trace/events/f2fs.h | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h
> index 53b96f12300c..e3dc031af7f5 100644
> --- a/include/trace/events/f2fs.h
> +++ b/include/trace/events/f2fs.h
> @@ -76,16 +76,7 @@ TRACE_DEFINE_ENUM(CP_TRIMMED);
> #define show_bio_type(op,op_flags) show_bio_op(op), \
> show_bio_op_flags(op_flags)
>
> -#define show_bio_op(op) \
> - __print_symbolic(op, \
> - { REQ_OP_READ, "READ" }, \
> - { REQ_OP_WRITE, "WRITE" }, \
> - { REQ_OP_FLUSH, "FLUSH" }, \
> - { REQ_OP_DISCARD, "DISCARD" }, \
> - { REQ_OP_SECURE_ERASE, "SECURE_ERASE" }, \
> - { REQ_OP_ZONE_RESET, "ZONE_RESET" }, \
> - { REQ_OP_WRITE_SAME, "WRITE_SAME" }, \
> - { REQ_OP_WRITE_ZEROES, "WRITE_ZEROES" })
> +#define show_bio_op(op) blk_op_str(op)
>
> #define show_bio_op_flags(flags) \
> __print_flags(F2FS_BIO_FLAG_MASK(flags), "|", \
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-06-21 7:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 17:59 [PATCH V5 0/5] block: improve print_req_error Chaitanya Kulkarni
2019-06-20 17:59 ` [PATCH V5 1/5] " Chaitanya Kulkarni
2019-06-20 17:59 ` [PATCH V5 2/5] block: add centralize REQ_OP_XXX to string helper Chaitanya Kulkarni
2019-06-21 7:38 ` Hannes Reinecke
2019-06-20 17:59 ` [PATCH V5 3/5] block: use blk_op_str() in blk-mq-debugfs.c Chaitanya Kulkarni
2019-06-21 7:38 ` Hannes Reinecke
2019-06-20 17:59 ` [PATCH V5 4/5] block: update print_req_error() Chaitanya Kulkarni
2019-06-21 7:39 ` Hannes Reinecke
2019-06-20 17:59 ` [PATCH V5 5/5] f2fs: use block layer helper for show_bio_op macro Chaitanya Kulkarni
2019-06-21 7:39 ` Hannes Reinecke [this message]
2019-06-20 19:04 ` [PATCH V5 0/5] block: improve print_req_error Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06714e3d-be00-8425-9888-edb46c1c4185@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.