From: Ben Hutchings <ben@decadent.org.uk>
To: Masahiro Yamada <masahiroy@kernel.org>, linux-kbuild@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Riku Voipio <riku.voipio@linaro.org>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH] kbuild: deb-pkg: change the source package name to 'linux'
Date: Mon, 19 Apr 2021 14:33:27 +0200 [thread overview]
Message-ID: <06ffa2a690d57f867b4bc1b42f0026917b1dd3cd.camel@decadent.org.uk> (raw)
In-Reply-To: <20210419070139.1515431-1-masahiroy@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1876 bytes --]
On Mon, 2021-04-19 at 16:01 +0900, Masahiro Yamada wrote:
> Change the source package name from 'linux-$(KERNELRELEASE)' to 'linux',
> which is aligned with the source package from the Debian community.
I would prefer that the source package name is *not* the same, so that
it is clearly distinguished from distribution packages.
Before commit 3716001bcb7f "deb-pkg: add source package" the binary
packages used to claim that the source package was "linux-upstream"
(although no such source package existed). Could we use that instead?
Ben.
> The filenames will be changed as follows:
>
> [before]
> linux-5.12.0-rc3+_5.12.0-rc3+-1.dsc
> linux-5.12.0-rc3+_5.12.0-rc3+.orig.tar.gz
> linux-5.12.0-rc3+_5.12.0-rc3+-1.diff.gz
>
> [After]
> linux_5.12.0-rc3+-1.dsc
> linux_5.12.0-rc3+.orig.tar.gz
> linux_5.12.0-rc3+-1.diff.gz
>
> Commit 3716001bcb7f ("deb-pkg: add source package") introduced
> KDEB_SOURCENAME. If you are unhappy with the default name, you can
> override it via KDEB_SOURCENAME.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> ---
>
> scripts/Makefile.package | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/Makefile.package b/scripts/Makefile.package
> index f952fb64789d..c5834a480545 100644
> --- a/scripts/Makefile.package
> +++ b/scripts/Makefile.package
> @@ -25,7 +25,7 @@ include $(srctree)/scripts/Kbuild.include
>
> # Remove hyphens since they have special meaning in RPM filenames
> KERNELPATH := kernel-$(subst -,_,$(KERNELRELEASE))
> -KDEB_SOURCENAME ?= linux-$(KERNELRELEASE)
> +KDEB_SOURCENAME ?= linux
> KBUILD_PKG_ROOTCMD ?="fakeroot -u"
> export KDEB_SOURCENAME
> # Include only those top-level files that are needed by make, plus the GPL copy
--
Ben Hutchings
Humour is the best antidote to reality.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-04-19 12:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 7:01 [PATCH] kbuild: deb-pkg: change the source package name to 'linux' Masahiro Yamada
2021-04-19 12:33 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ffa2a690d57f867b4bc1b42f0026917b1dd3cd.camel@decadent.org.uk \
--to=ben@decadent.org.uk \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=riku.voipio@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.